> On April 26, 2016, 6:51 a.m., Puneet Gupta wrote: > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java, > > line 819 > > <https://reviews.apache.org/r/46635/diff/2/?file=1361032#file1361032line819> > > > > This conf may be required again on restart. Do we need to save it in > > AbstractQueryContext#lensConf ?
Seems we need LENS-1013 which is moving updateConf to AbstractQueryContext. Will update once LENS-1013 is merged. - Amareshwari ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46635/#review130546 ----------------------------------------------------------- On April 26, 2016, 6:12 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46635/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 6:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-1016 > https://issues.apache.org/jira/browse/LENS-1016 > > > Repository: lens > > > Description > ------- > > - Priority gets set from rewriteAnDSelect > - removed method to decide and set from AbstractQueryContext > - Updated HiveDriver.decidePriority to do calculation when ctx.getPriority() > is null instead of looking at value from conf. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > aa37dcc > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > ba3f3d5 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > b568ffb > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > 7e9fda9 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 42bd4ab > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > df13ba2 > > Diff: https://reviews.apache.org/r/46635/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
