----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46632/#review130738 -----------------------------------------------------------
lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java (line 271) <https://reviews.apache.org/r/46632/#comment194611> Can we have better name for the query WRONG_HIVE_CUBE_QUERY because here the query is succeeding. One would assume the query WRONG_HIVE_CUBE_QUERY would always fail. lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java (line 337) <https://reviews.apache.org/r/46632/#comment194614> Since this test is checking footer, Can we change the variable names from header, header1 to content,lines just like previous test ? lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java (line 339) <https://reviews.apache.org/r/46632/#comment194615> Since, outputfile will have one row extra than result.getNumRows(), Wouldn't header1[result.getNumRows()+1] throw arrayOutOfBound exception ? - Deepak Barr On April 26, 2016, 8:06 a.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46632/ > ----------------------------------------------------------- > > (Updated April 26, 2016, 8:06 a.m.) > > > Review request for lens, Deepak Barr and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Adding session config tests to regression > > > Diffs > ----- > > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > 9355e47 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > 753a7b4 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java > d193c9c > > lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java > e2148e3 > > lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java > 3bb30d8 > > lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/46632/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.034s] > [INFO] Lens .............................................. SUCCESS [3.355s] > [INFO] Lens API .......................................... SUCCESS [21.708s] > [INFO] Lens API for server and extensions ................ SUCCESS [15.549s] > [INFO] Lens Cube ......................................... SUCCESS > [17:47.795s] > [INFO] Lens DB storage ................................... SUCCESS [15.783s] > [INFO] Lens Query Library ................................ SUCCESS [12.144s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:36.127s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [30.377s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [14.472s] > [INFO] Lens Server ....................................... SUCCESS > [15:09.623s] > [INFO] Lens client ....................................... SUCCESS [28.785s] > [INFO] Lens CLI .......................................... SUCCESS [2:27.518s] > [INFO] Lens Examples ..................................... SUCCESS [7.678s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.632s] > [INFO] Lens Distribution ................................. SUCCESS [8.770s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:07.472s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.686s] > [INFO] Lens Regression ................................... SUCCESS [9.408s] > [INFO] Lens UI ........................................... SUCCESS [41.943s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 42:43.736s > [INFO] Finished at: Mon Apr 25 12:26:00 UTC 2016 > [INFO] Final Memory: 170M/1968M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
