----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47301/#review133541 -----------------------------------------------------------
lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java (line 288) <https://reviews.apache.org/r/47301/#comment198030> We need not check running and queued list twice per loop iteration. Something like this should be fine - for (int t = 0; t < timeToWait; t = t + sleepTime ) { List<QueryHandle> running = qHelper.getQueryHandleList(null, "RUNNING", "all", sessionHandleString, null, null, hiveDriver); List<QueryHandle> queued = qHelper.getQueryHandleList(null, "QUEUED", "all", sessionHandleString, null, null, hiveDriver); logger.info("Running query count : " + running.size() + "\t Queued query count : " + queued.size()); Assert.assertTrue(running.size() < 4); if (running.isEmpty() && queued.isEmpty()) { break; } TimeUnit.SECONDS.sleep(sleepTime); } lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java (line 331) <https://reviews.apache.org/r/47301/#comment198029> Not sure, but will the last comma throw an error ? {longRunningQuery, COST_5, COST_5, COST_3, COST_2, }; - Deepak Barr On May 17, 2016, 6:57 a.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47301/ > ----------------------------------------------------------- > > (Updated May 17, 2016, 6:57 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Deepak Barr, Rajat > Khandelwal, and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > Adding user cost ceiling tests > > > Diffs > ----- > > lens-regression/pom.xml b9841e8 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java > c0fc15a > lens-regression/src/main/resources/queries.properties PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java > d942e3c > > lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java > f326a4f > > lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java > d3b8ffb > > lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47301/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.978s] > [INFO] Lens .............................................. SUCCESS [3.996s] > [INFO] Lens API .......................................... SUCCESS [20.521s] > [INFO] Lens API for server and extensions ................ SUCCESS [16.392s] > [INFO] Lens Cube ......................................... SUCCESS > [14:46.227s] > [INFO] Lens DB storage ................................... SUCCESS [16.187s] > [INFO] Lens Query Library ................................ SUCCESS [13.004s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:22.171s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.077s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [23.482s] > [INFO] Lens Server ....................................... SUCCESS [8:42.013s] > [INFO] Lens client ....................................... SUCCESS [1:30.298s] > [INFO] Lens CLI .......................................... SUCCESS [1:17.992s] > [INFO] Lens Examples ..................................... SUCCESS [8.909s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.644s] > [INFO] Lens Distribution ................................. SUCCESS [9.850s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:08.855s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.197s] > [INFO] Lens Regression ................................... SUCCESS [10.979s] > [INFO] Lens UI ........................................... SUCCESS [42.076s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 32:17.865s > [INFO] Finished at: Thu May 12 12:03:42 UTC 2016 > [INFO] Final Memory: 195M/2815M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Archana H > >
