-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47415/#review133703
-----------------------------------------------------------


Ship it!




Ship It!

- Amareshwari Sriramadasu


On May 17, 2016, 8:38 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47415/
> -----------------------------------------------------------
> 
> (Updated May 17, 2016, 8:38 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-1040
>     https://issues.apache.org/jira/browse/LENS-1040
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> Cubesegmentation commands have prefix as cube, the auto completion and help 
> for cube commands is not working. Changed the name to Segmentation.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd 4a6a5d7 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensCubeSegmentationCommands.java
>  ed2ad7a 
>   
> lens-cli/src/main/java/org/apache/lens/cli/commands/annotations/LensSegmentationCommands.java
>  PRE-CREATION 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensCubeSegmentationCommands.java
>  53a52de 
>   
> lens-cli/src/test/java/org/apache/lens/cli/TestLensSegmentationCommands.java 
> PRE-CREATION 
>   lens-cli/src/test/resources/seg1.xml 848ac10 
>   lens-client/src/main/java/org/apache/lens/client/LensClient.java 43da691 
>   lens-client/src/main/java/org/apache/lens/client/LensMetadataClient.java 
> f2d42ca 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
>  c8190bc 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegment.java 
> 8143c3b 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeSegmentation.java 
> a93fafe 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> 1aae267 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Segment.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java 
> PRE-CREATION 
>   
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
>  d992967 
>   lens-examples/src/main/java/org/apache/lens/examples/SampleMetastore.java 
> a04a67f 
>   lens-examples/src/main/resources/seg1.xml c1576d7 
>   lens-examples/src/test/resources/yaml/seg1.yaml dd2f339 
>   
> lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java
>  431164f 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  c503f16 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 1e11325 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java
>  7395c83 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  d5f5561 
> 
> Diff: https://reviews.apache.org/r/47415/diff/
> 
> 
> Testing
> -------
> 
> Autocomplete works fine after the change.
> 
> lens-shell>describe cube --name
> 
> required --name: <cube_name>; no default value
> lens-shell>describe segmentation --name
> 
> required --name: <segmentation_name>; no default value
> 
> mvn clean install :
> 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.679s]
> [INFO] Lens .............................................. SUCCESS [3.092s]
> [INFO] Lens API .......................................... SUCCESS [21.178s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.301s]
> [INFO] Lens Cube ......................................... SUCCESS 
> [16:05.876s]
> [INFO] Lens DB storage ................................... SUCCESS [20.191s]
> [INFO] Lens Query Library ................................ SUCCESS [17.287s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:01.680s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [54.227s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [28.268s]
> [INFO] Lens Server ....................................... SUCCESS [8:56.806s]
> [INFO] Lens client ....................................... SUCCESS [1:32.014s]
> [INFO] Lens CLI .......................................... SUCCESS [1:22.838s]
> [INFO] Lens Examples ..................................... SUCCESS [7.968s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.646s]
> [INFO] Lens Distribution ................................. SUCCESS [9.414s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:09.452s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.375s]
> [INFO] Lens Regression ................................... SUCCESS [10.515s]
> [INFO] Lens UI ........................................... SUCCESS [28.040s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 34:51.750s
> [INFO] Finished at: Tue May 17 07:41:20 UTC 2016
> [INFO] Final Memory: 200M/2555M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Reply via email to