----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47820/#review134729 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java (line 41) <https://reviews.apache.org/r/47820/#comment199623> Can there be a case where selectedDriver is not JDBCDriver ? then we are actually returning false. lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java (line 46) <https://reviews.apache.org/r/47820/#comment199624> Seems wrong - Amareshwari Sriramadasu On May 25, 2016, 7:15 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47820/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 7:15 a.m.) > > > Review request for lens. > > > Bugs: LENS-1155 > https://issues.apache.org/jira/browse/LENS-1155 > > > Repository: lens > > > Description > ------- > > Issue : > When user launching InMemory Queries, the connection is released back to pool > only after result set is read completely or after query is purged. For > InMemory Queries (not persisted by lens server), the query state is changed > to SUCCESSFUL even before connection is released.This causes connection pool > to throw error for new queries whenever JDBC driver is running at almost full > load. > > Fix : > Added a new constraint at JDBC driver to check max allowed connections. At > any given time to launch a query the number of query context objects held by > driver should be less than connection pool max size. > > > Diffs > ----- > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 044a19c > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraint.java > PRE-CREATION > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/MaxJDBCConnectionCheckConstraintFactory.java > PRE-CREATION > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml b5b6164 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 4eee354 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 67f6c1f > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > b2319a9 > lens-server-api/src/main/java/org/apache/lens/server/api/util/LensUtil.java > a0691a5 > > Diff: https://reviews.apache.org/r/47820/diff/ > > > Testing > ------- > > > Thanks, > > Sushil Mohanty > >
