----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47823/#review134738 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On May 25, 2016, 2:42 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47823/ > ----------------------------------------------------------- > > (Updated May 25, 2016, 2:42 p.m.) > > > Review request for lens. > > > Bugs: LENS-1149 > https://issues.apache.org/jira/browse/LENS-1149 > > > Repository: lens > > > Description > ------- > > Current code of writing inner ast is handled correctly only for aggregate > functions, non aggregate functions and simple columns. Expressions like "col1 > = x or col2 = y" or round(sum(measure)) are not handled correctly. > > Fixed the code to do outer aggregates and inner aggregates appropriate > whereever aggregates exist and all other expressions will have proper aliases > created. With attached code - all cases should be handled correctly. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/SingleFactMultiStorageHQLContext.java > 1af031a > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2ab3fd0 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > 5eea123 > > Diff: https://reviews.apache.org/r/47823/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > Tests run: 399, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,308.142 > sec - in TestSuite > > Results : > > Tests run: 399, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Amareshwari Sriramadasu > >
