----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47777/#review135156 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightedQueryCostDriverSelector.java (line 54) <https://reviews.apache.org/r/47777/#comment200179> Let's keep the default value consistent. Also, define a constant int in `LensConfConstants` for the constant. lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (lines 93 - 117) <https://reviews.apache.org/r/47777/#comment200185> Anonymous class not needed. Can use `FactPartitionBasedQueryCost` lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (line 120) <https://reviews.apache.org/r/47777/#comment200186> `private` lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (line 121) <https://reviews.apache.org/r/47777/#comment200252> Keep this variable as a class level variable to avoid redundant recreation of objects in each test case. lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (line 177) <https://reviews.apache.org/r/47777/#comment200253> Change the name to make more descriptive. `testCustomWeights` or something. Same for other test functions. lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java (lines 212 - 229) <https://reviews.apache.org/r/47777/#comment200251> The verification code can be abstracted out. Exactly same sequence of operations have been used in the first test case, the difference being of ratio variables and `33.33`. - Rajat Khandelwal On May 26, 2016, 3:37 p.m., Anshul Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47777/ > ----------------------------------------------------------- > > (Updated May 26, 2016, 3:37 p.m.) > > > Review request for lens. > > > Bugs: LENS-661 > https://issues.apache.org/jira/browse/LENS-661 > > > Repository: lens > > > Description > ------- > > Added Weighted selector > > > Diffs > ----- > > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > 82672294fcbf462db1fd75f00e796d5dae9d2c22 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 85f54d1f835f86dd6122a987525853e0ffa9488c > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/WeightedQueryCostDriverSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestMinCostSelector.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/TestWeightedCostSelector.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47777/diff/ > > > Testing > ------- > > Here's the reactor summary after running mvn clean package > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Server ........................................ SUCCESS [11:32 > min] > [INFO] Lens client ........................................ SUCCESS [01:49 > min] > [INFO] Lens CLI ........................................... SUCCESS [02:02 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 8.430 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 2.801 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 21.429 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [02:28 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 20.690 > s] > [INFO] Lens Regression .................................... SUCCESS [ 9.313 > s] > [INFO] Lens UI ............................................ SUCCESS [ 14.163 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 19:10 min > [INFO] Finished at: 2016-05-24T20:31:02+05:30 > [INFO] Final Memory: 103M/466M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Anshul Gupta > >
