-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48329/
-----------------------------------------------------------

(Updated June 7, 2016, 3:11 p.m.)


Review request for lens.


Bugs: LENS-1172
    https://issues.apache.org/jira/browse/LENS-1172


Repository: lens


Description
-------

The test class has an AfterMethod tearDown method, which drops a table and 
closes a session. But the session and the table don't get created until the 
test method of this class is run. Furthermore, this test depends on other test 
groups. So if any of the tests of those groups fail, the tests of this class 
won't be run. But the tearDown will still be run since setUp was run too. 

Proposed fix is to drop the table and close the session in the test method 
itself.


Diffs (updated)
-----

  
lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java
 082840300e983b90bc2c43fb8555bf1860fe6bbc 

Diff: https://reviews.apache.org/r/48329/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Reply via email to