> On June 9, 2016, 10:26 a.m., Amareshwari Sriramadasu wrote: > >
Pre-commit passed with revision 15. > On June 9, 2016, 10:26 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java, > > line 327 > > <https://reviews.apache.org/r/47174/diff/14/?file=1411482#file1411482line327> > > > > Should we have few queries in queued state for testing the queued and > > their session being closed. > > > > Or such a test already exists? Tested in `TestQueryIndependenceFromSession`. There, two queries are fired despite knowing that only 1 can run on the driver, so the other will be in queue. Then Session close doesn't affect the query. It still succeeds. > On June 9, 2016, 10:26 a.m., Amareshwari Sriramadasu wrote: > > lens-query-lib/src/main/java/org/apache/lens/lib/query/AbstractFileFormatter.java, > > line 98 > > <https://reviews.apache.org/r/47174/diff/14/?file=1411470#file1411470line98> > > > > Can you update to master? Updated. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47174/#review136756 ----------------------------------------------------------- On June 9, 2016, 11:20 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47174/ > ----------------------------------------------------------- > > (Updated June 9, 2016, 11:20 a.m.) > > > Review request for lens. > > > Bugs: LENS-904 > https://issues.apache.org/jira/browse/LENS-904 > > > Repository: lens > > > Description > ------- > > In the current scenario, if the queries are queued from lens side (because of > throttling), then these queries fails on session close. > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 395d63b87b385607fbb0435bd99ab05b65ca51dd > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > c49b5e860c9c30c54e7a58c629e47ffe60709f62 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 04d059d65f1ac0ee0f50691cde946d00cbdc57fe > > lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 3e9f28661132366cd92837265a0a0f7119a24853 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 15ed2229dc21a730140efa5a7297d9c0329cabbc > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > b96cdf0585b285e449dde0e77467f44cbda07d0a > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > 2443fecea303ed963bfcd82071f4ca69ded46227 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > fde432f89bf22b564ccb4a952fb9ba1ae42721ac > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > c70689b110462e9623e1e3b5d37af97270c673dc > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 6c5e52d150bdbbb1075d9150901068bbd3400594 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 04812a6266a71b4224afb0345b02d43a7c58c4fd > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > b5d54829ce4c41145eda39702af9f26ed0958fde > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > f3d72f4b371020602e5eea0e5c538d5fc1b40de9 > > lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java > 2c426311928d007cd3be26ad433dbce1428a37d9 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > 8493d8598adc07609be1ddf4de5734513db7b1eb > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > a85cf985153417007842231a7ad1b368038490e8 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java > 45bdfbe4545416d830e759e38bbf1634bd746099 > > Diff: https://reviews.apache.org/r/47174/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
