----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49096/#review139213 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 1127) <https://reviews.apache.org/r/49096/#comment204349> Should we have separate driver and end point for scheduler? I'm thinking, We should use the server db directly and talk to so many end points. lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java (line 71) <https://reviews.apache.org/r/49096/#comment204350> handleId should never be null. Do you want to give a @NonNull annotation instead of this check ? lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java (line 75) <https://reviews.apache.org/r/49096/#comment204351> Same as above, should never be null. lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java (line 30) <https://reviews.apache.org/r/49096/#comment204353> We should create this through configuration and default should be HSQL - Amareshwari Sriramadasu On June 22, 2016, 4:04 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49096/ > ----------------------------------------------------------- > > (Updated June 22, 2016, 4:04 p.m.) > > > Review request for lens. > > > Bugs: LENS-988 > https://issues.apache.org/jira/browse/LENS-988 > > > Repository: lens > > > Description > ------- > > Stores the Job definitions and job instance definitions. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobHandle.java > 4a2baba > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInfo.java > 92260b5 > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceHandle.java > f19d3f0 > > lens-api/src/main/java/org/apache/lens/api/query/SchedulerJobInstanceInfo.java > 9146cf0 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0a81f7b > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 2bcf0d6 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobHandle.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceHandle.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceInfo.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobInstanceState.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerJobState.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > f575bc8 > > lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > 838b9b8 > > Diff: https://reviews.apache.org/r/49096/diff/ > > > Testing > ------- > > To be updated. > > > Thanks, > > Lavkesh Lahngir > >
