----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49621/#review140724 -----------------------------------------------------------
LGTM - Puneet Gupta On July 5, 2016, 5:35 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49621/ > ----------------------------------------------------------- > > (Updated July 5, 2016, 5:35 a.m.) > > > Review request for lens. > > > Bugs: LENS-1208 > https://issues.apache.org/jira/browse/LENS-1208 > > > Repository: lens > > > Description > ------- > > Fixes join condition for outer join of multi fact queries for expression > attributes > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 187d98d > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 898c438 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > ea6b4a1 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > d17c18f > > Diff: https://reviews.apache.org/r/49621/diff/ > > > Testing > ------- > > ------------------------------------------------------- > T E S T S > ------------------------------------------------------- > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option PermSize=256m; > support was removed in 8.0 > Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=256m; > support was removed in 8.0 > Running TestSuite > Tests run: 399, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,183.426 > sec - in TestSuite > > Results : > > Tests run: 399, Failures: 0, Errors: 0, Skipped: 0 > > > Thanks, > > Amareshwari Sriramadasu > >
