----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50603/#review144079 -----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java (line 511) <https://reviews.apache.org/r/50603/#comment210068> Do we need this configurable ? We can try either way and log the output if its not supported (SQLFeatureNotSupportedException) - Puneet Gupta On July 29, 2016, 10:48 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50603/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 10:48 a.m.) > > > Review request for lens. > > > Bugs: LENS-1242 > https://issues.apache.org/jira/browse/LENS-1242 > > > Repository: lens > > > Description > ------- > > - Updated JDBCDriver cancel to call statement.cancel > - At JDBCDriver level we can configure if statement.cancel is supported or > not. If set to false, it wont be called. > - Extened cancel test actually run a long running query and cancel it. > > > Diffs > ----- > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 8047302 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > ac0682d > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 66645b9 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 491aa69 > lens-driver-jdbc/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml > 1202074 > src/site/apt/admin/jdbcdriver-config.apt 96c98ad > > Diff: https://reviews.apache.org/r/50603/diff/ > > > Testing > ------- > > > Thanks, > > Amareshwari Sriramadasu > >
