-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50714/#review144718
-----------------------------------------------------------




lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
(line 58)
<https://reviews.apache.org/r/50714/#comment210774>

    Lets name the constants ending with _PFX


- Amareshwari Sriramadasu


On Aug. 3, 2016, 8:07 a.m., Sushil Mohanty wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50714/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 8:07 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Bugs: LENS-197
>     https://issues.apache.org/jira/browse/LENS-197
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> With this change user can specify start and end time of a fact column. Based 
> on the range  of the input query, fact tables will be pruned or considered to 
> answer.
> 
> 
> Diffs
> -----
> 
>   lens-api/src/main/resources/cube-0.1.xsd d6c6bd2 
>   
> lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java 
> 61675bc 
>   
> lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java
>  12d6e3a 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java 
> c1fd0a5 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java 
> PRE-CREATION 
>   lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java 
> 06ba148 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java 
> 48652f2 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java 
> d42d494 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java 
> fff6f24 
>   lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java 
> 857bc90 
>   lens-examples/src/main/resources/fact1.xml effdfac 
>   lens-examples/src/test/resources/yaml/fact1.yaml 4252e33 
>   
> lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java
>  c1f9a02 
>   lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java 
> 1b6b819 
>   
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
>  61bc133 
> 
> Diff: https://reviews.apache.org/r/50714/diff/
> 
> 
> Testing
> -------
> 
> mvn clean install : 
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.002s]
> [INFO] Lens .............................................. SUCCESS [3.318s]
> [INFO] Lens API .......................................... SUCCESS [21.138s]
> [INFO] Lens API for server and extensions ................ SUCCESS [17.260s]
> [INFO] Lens Cube ......................................... SUCCESS 
> [15:00.074s]
> [INFO] Lens DB storage ................................... SUCCESS [16.701s]
> [INFO] Lens Query Library ................................ SUCCESS [13.182s]
> [INFO] Lens Hive Driver .................................. SUCCESS [1:22.717s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [36.557s]
> [INFO] Lens Elastic Search Driver ........................ SUCCESS [20.234s]
> [INFO] Lens Server ....................................... SUCCESS 
> [13:07.795s]
> [INFO] Lens client ....................................... SUCCESS [1:30.234s]
> [INFO] Lens CLI .......................................... SUCCESS [1:18.126s]
> [INFO] Lens Examples ..................................... SUCCESS [8.328s]
> [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.753s]
> [INFO] Lens Distribution ................................. SUCCESS [9.091s]
> [INFO] Lens ML Lib ....................................... SUCCESS [1:08.829s]
> [INFO] Lens ML Ext Distribution .......................... SUCCESS [1.958s]
> [INFO] Lens Regression ................................... SUCCESS [12.572s]
> [INFO] Lens UI ........................................... SUCCESS [27.022s]
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 36:38.799s
> [INFO] Finished at: Tue Aug 02 18:39:14 UTC 2016
> [INFO] Final Memory: 189M/2043M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sushil Mohanty
> 
>

Reply via email to