> On Aug. 4, 2016, 1:05 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java, > > line 271 > > <https://reviews.apache.org/r/50784/diff/1/?file=1462730#file1462730line271> > > > > You don't need to get query service here. This should be doable with > > the session service itself.
unfortunately SessionService does not extends BaseLensService - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50784/#review144754 ----------------------------------------------------------- On Aug. 4, 2016, 9:33 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50784/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 9:33 a.m.) > > > Review request for lens. > > > Bugs: LENS-1257 > https://issues.apache.org/jira/browse/LENS-1257 > > > Repository: lens > > > Description > ------- > > Server side changes for session API. > > P.S. Lots of changes are just formatting differences. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/session/UserSessionInfo.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 19a86c6 > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > fdfd09c > > Diff: https://reviews.apache.org/r/50784/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
