> On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java, > > line 88 > > <https://reviews.apache.org/r/50814/diff/1/?file=1463268#file1463268line88> > > > > This would require changes in specs. > > > > ```<xs:element type="xs:string" name="resource_path" minOccurs="0" > > maxOccurs="unbounded"> > > <xs:annotation> > > <xs:documentation> > > Path for resources like jars etc. e.g. > > /path/to/my/jar > > </xs:documentation> > > </xs:annotation> > > </xs:element> > > ``` > > > > Followed by changes in test cases, regression tests and clients using > > the REST API. > > > > So either let's make those changes right now to minimize trickle down > > effect, or let's decide that we'll infer type from the file's extension.
Yeah. It's easy to do right now. > On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java, > > lines 216-218 > > <https://reviews.apache.org/r/50814/diff/1/?file=1463266#file1463266line216> > > > > Shouldn't be needed. `GenericExceptionMapper` will take care to ruturn > > the correct `APIResult`. Can you verify through test cases? I am thinking to fix all the API things in separate JIRA. Lots of message formatting has to be done. > On Aug. 5, 2016, 9:30 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java, > > lines 156-183 > > <https://reviews.apache.org/r/50814/diff/1/?file=1463266#file1463266line156> > > > > Can we add documentations for all these functions so that they can be > > reflected in http://lens.apache.org/resource_ScheduleResource.html Yes. We will do. Just after bug fixes. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50814/#review144898 ----------------------------------------------------------- On Aug. 4, 2016, 6:10 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50814/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2016, 6:10 p.m.) > > > Review request for lens. > > > Bugs: LENS-1265 > https://issues.apache.org/jira/browse/LENS-1265 > > > Repository: lens > > > Description > ------- > > 1. Scheduler's submit job is not setting db and session config passed > 2. Scheduler's getJobDefinition api is giving response status 500 > 3. Instance run result path is set NULL in job_instance_run_table > 4. Delete on scheduler job is failing with NPE > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java > b19248f > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java > 52b56ca > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java > e6c1571 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceState.java > 93d3d7e > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobState.java > ffaae6c > > lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java > 217879f > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 8603edf > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > 7a2b06a > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > 7323add > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java > 5b12720 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 14ca32d > > Diff: https://reviews.apache.org/r/50814/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
