----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51730/#review148303 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java (line 226) <https://reviews.apache.org/r/51730/#comment215783> Its passing a new LensConf() here, instead should be passing the conf which was persisted. - Amareshwari Sriramadasu On Sept. 8, 2016, 4:21 p.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51730/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 4:21 p.m.) > > > Review request for lens. > > > Bugs: LENS-1317 > https://issues.apache.org/jira/browse/LENS-1317 > > > Repository: lens > > > Description > ------- > > LENS-1317 Lens Query Conf to be persisted in Finished_Queries store > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 1d56757 > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > 47159b5 > lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java > 74d9a1f > > Diff: https://reviews.apache.org/r/51730/diff/ > > > Testing > ------- > > Unit Tests modified to cover the changes. > > > Thanks, > > Srikanth Sundarrajan > >
