----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51457/#review148304 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java (line 225) <https://reviews.apache.org/r/51457/#comment215784> Can you do slf4j parameterized logging? lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java (line 50) <https://reviews.apache.org/r/51457/#comment215785> Put back the groups annotation. - Amareshwari Sriramadasu On Sept. 8, 2016, 12:16 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51457/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2016, 12:16 p.m.) > > > Review request for lens. > > > Bugs: LENS-1286 > https://issues.apache.org/jira/browse/LENS-1286 > > > Repository: lens > > > Description > ------- > > When the server is restarted, it reads all instances which where in WAITING, > LAUNCHED or RUNNING states. > If the instance is in WAITING or LAUNCHED state, it is killed and it is rerun. > If the instance is in RUNNING state, it will check the query status and > update accordingly. > > P.S. Ignore ResourceTest file. It is in separate review request. > > > Diffs > ----- > > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > 966a64e > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java > 077d531 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 9cee0c2 > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerRestartTest.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java > 130df5f > > lens-server/src/test/java/org/apache/lens/server/scheduler/util/SchedulerTestUtils.java > a36b2aa > > Diff: https://reviews.apache.org/r/51457/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
