> On Sept. 13, 2016, 1:06 p.m., Puneet Gupta wrote: > > lens-client/src/main/java/org/apache/lens/client/LensClient.java, line 120 > > <https://reviews.apache.org/r/51756/diff/1/?file=1494959#file1494959line120> > > > > Just had one thought. Is there a way to keep the number of public > > methods to a minimum in LensClient and LensStatement. The motivation for > > this would be have lesser number of execute methods to choose from for end > > user who sometimes seem to struggle which method to use. I Dont see a > > direct way of doing that unless we sacrifice backward compatibility.
While I understand the concern, it would be much needed to expose the ability to pass the conf, given that the server supports the client to pass conf. Removing the older method without conf, would be backward incompatible, I suggest that we annotate the older methods as @Derprecated and remove them in a subsequent release. - Srikanth ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51756/#review148713 ----------------------------------------------------------- On Sept. 9, 2016, 11:09 a.m., Srikanth Sundarrajan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51756/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 11:09 a.m.) > > > Review request for lens. > > > Bugs: LENS-1319 > https://issues.apache.org/jira/browse/LENS-1319 > > > Repository: lens > > > Description > ------- > > LENS-1319 Lens Client doesn't provide the option to pass query conf while > submitting the query > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClient.java 9a76118 > lens-client/src/main/java/org/apache/lens/client/LensStatement.java 64c24c7 > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 94a788a > > Diff: https://reviews.apache.org/r/51756/diff/ > > > Testing > ------- > > Relevant unit tests added. > > > Thanks, > > Srikanth Sundarrajan > >
