----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51652/#review150398 -----------------------------------------------------------
lens-regression/pom.xml (line 81) <https://reviews.apache.org/r/51652/#comment218370> Shouldn't be needed as compile is the default scope: https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Dependency_Scope lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SavedQueryResourceHelper.java (lines 72 - 93) <https://reviews.apache.org/r/51652/#comment218373> Other than the entity, both methods have the same body? Can we merge them into one method with extra argument? lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SavedQueryResourceHelper.java (line 193) <https://reviews.apache.org/r/51652/#comment218375> if you read like this: `response.readEntity(new GenericType<LensAPIResult<QueryHandle>>{});` then the return type can be `LensAPIResult<QueryHandle>` and castings e.g. at https://reviews.apache.org/r/51652/diff/1?page=2#22 line 117 can be avoided. lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java (line 203) <https://reviews.apache.org/r/51652/#comment218374> Should we also somehow add asserts on the mail sent? lens-regression/src/test/java/org/apache/lens/regression/client/ITSavedQueryTests.java (line 233) <https://reviews.apache.org/r/51652/#comment218376> Anything to be done here? lens-regression/src/test/java/org/apache/lens/regression/client/ITScheduleQueryTests.java (line 78) <https://reviews.apache.org/r/51652/#comment218377> shuold this be submitJob? Similar for other functions of this class. - Rajat Khandelwal On Sept. 6, 2016, 7:03 p.m., Archana H wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51652/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2016, 7:03 p.m.) > > > Review request for lens, Deepak Barr, Lavkesh Lahngir, Rajat Khandelwal, and > Puneet Gupta. > > > Repository: lens > > > Description > ------- > > - Adding tests for > * Saved query > * Scheduler feature > * 2.6 release bug fixes > - Some code cleanup > > > Diffs > ----- > > lens-regression/pom.xml 5155120 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/SessionURL.java > 365146b > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensHelper.java > c74da5d > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/LensServerHelper.java > 8019182 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/MetastoreHelper.java > e993256 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/QueryHelper.java > dbbb4aa > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SavedQueryResourceHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ScheduleResourceHelper.java > PRE-CREATION > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java > eb49827 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/SessionHelper.java > 6c01d1e > > lens-regression/src/main/java/org/apache/lens/regression/core/testHelper/BaseTestClass.java > f442983 > > lens-regression/src/main/java/org/apache/lens/regression/core/type/MapBuilder.java > 59d99a3 > > lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java > b2af76b > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 2e48e80 > lens-regression/src/test/java/org/apache/lens/regression/ITMetricsTest.java > dad7b07 > > lens-regression/src/test/java/org/apache/lens/regression/ITPriorityTests.java > 1bae767 > > lens-regression/src/test/java/org/apache/lens/regression/ITRestartTests.java > 70d1289 > > lens-regression/src/test/java/org/apache/lens/regression/ITStreamingTests.java > d28b2ac > lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java > 255f5be > > lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java > 1652ba3 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java > 6292867 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java > 2d0c3f1 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITSavedQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/ITScheduleQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java > e7f40e7 > > lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java > 00fc729 > > lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java > 8294075 > > lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java > bf9de6c > > lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java > 8fea48b > > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java > 91d447b > pom.xml eb57714 > > Diff: https://reviews.apache.org/r/51652/diff/ > > > Testing > ------- > > > Thanks, > > Archana H > >
