-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52548/
-----------------------------------------------------------

(Updated Oct. 9, 2016, 11:54 a.m.)


Review request for lens.


Bugs: LENS-1345
    https://issues.apache.org/jira/browse/LENS-1345


Repository: lens


Description
-------

JDBC query is launched in a thread. On query finish, the thread calls back the 
query service to update status, which creates a FinishedQuery instance. In the 
constructor, FinishedQuery is fetching result from the jdbc driver, which waits 
on the original thread to complete. Basically the thread is waiting for itself. 

In the callback, query context is acquired by the thread, and can't be acquired 
again. Which means that get calls for this query won't return and will stay 
blocked. This can end up blocking all the grizzly threads.


Diffs (updated)
-----

  lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 
f805ec6ebccd18de3bfcd0f1ab8626f7330dd6f1 
  
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 
6e9086f9e8dc302ad2171d7f5636a24cb79dcb50 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java
 e4984798751d012f0a9d01980df833c206155546 
  
lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryStatus.java
 033f6777b4be7a1b6d6cdc350e42a94ade1acbca 
  
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java
 b584c6a6d414a6f0dac509e67c8944dbd2373325 
  
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
 87d7cb0d5036bd0de4361cc146404a7fee478bac 
  lens-server/src/test/java/org/apache/lens/server/common/RestAPITestUtil.java 
57786e6cad53651b1a3256c0a76437c6e43c2c77 
  lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 
3f71aef9ca180d834538604925c71d1d87be8e26 

Diff: https://reviews.apache.org/r/52548/diff/


Testing
-------


Thanks,

Rajat Khandelwal

Reply via email to