----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52924/#review153254 -----------------------------------------------------------
lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38) <https://reviews.apache.org/r/52924/#comment222531> lens-driver-hive/src/main/resources/hivedriver-default.xml (line 38) <https://reviews.apache.org/r/52924/#comment222532> We can stop supporting the old property "lens.driver.hive.query.hook.class" since we are chnaging the package anyway (incomptible change) lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java (line 22) <https://reviews.apache.org/r/52924/#comment222536> Package change is an incompatible change for people implementing their hooks. Can we leave and comment of JIRA and also tag it incompatible lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java (line 36) <https://reviews.apache.org/r/52924/#comment222537> Comment needs update. lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java (line 131) <https://reviews.apache.org/r/52924/#comment222540> This should be the driver that created this hook (and not selected driver) lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java (line 74) <https://reviews.apache.org/r/52924/#comment222545> Can we move the parser to non error package ? - Puneet Gupta On Oct. 18, 2016, 2:35 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52924/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2016, 2:35 p.m.) > > > Review request for lens. > > > Bugs: LENS-1359 > https://issues.apache.org/jira/browse/LENS-1359 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/error/parse/Parser.java > PRE-CREATION > lens-driver-hive/src/main/resources/hivedriver-default.xml > f5fd3bb20b9d6b82292c4483d860ea14c8104c5c > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 43b33f331f4d9017d76bccbe0f6936aaeb184f8f > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > 961ec4ec781d3d7fd0f28edc4f23e9b39549592f > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6ca126f0a3535974352adf97e7a495838f > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > 8f30aa06ab234cedb53acb17544210ba4190ab53 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverConfiguration.java > 69a1a0b7ce57c24602a17ea7c97c0664a77c6568 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryHook.java > f8a9ee07d8c8b737a41de339ab44ca7752c90748 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > 146223942d05cfd952599297144e2a6bc02df273 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/NoOpDriverQueryHook.java > 4f1f2eb99ed0bec8e6e471a9723a6b002a092202 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/DriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/NoOpDriverQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHook.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java > 476855021288ff0d91762d240cb04c8aea9d302b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java > 4712f11e94f93d34b71f4f3ddb7c19af003d9fca > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/DriverConfigurationTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/ChainedDriverQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/QueryCostBasedQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/hooks/UserBasedQueryHookTest.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/user/MockDriverQueryHook.java > f70979abf7c44d3b4ed3588628de5a7517adfa81 > lens-server/src/main/resources/lensserver-default.xml > 8e5fe8a2b7f9ddfcadef104189b89c40ca1b3df6 > pom.xml 4928c1fa840fc51e4383ed4803f94102aa833221 > src/site/apt/admin/config.apt f22fc0c36f53fa7227dc990c58a079e66630a2a1 > src/site/apt/admin/hivedriver-config.apt > b1a25c3b5bb58fc2d0773dc168c110ee5e60c635 > > Diff: https://reviews.apache.org/r/52924/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
