----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51964/#review153851 -----------------------------------------------------------
lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java (line 135) <https://reviews.apache.org/r/51964/#comment223366> Make the argument File instead of String. lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 372) <https://reviews.apache.org/r/51964/#comment223367> Please add unit test for the client api/cli command lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java (line 841) <https://reviews.apache.org/r/51964/#comment223368> local directory need not be qualified, as it will be always local. lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java (line 23) <https://reviews.apache.org/r/51964/#comment223369> required import? lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 90) <https://reviews.apache.org/r/51964/#comment223370> Can we store resourceFs which is a FileSystem object as class variable, instead of creating newInstance on every download ? lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 109) <https://reviews.apache.org/r/51964/#comment223371> Lets move super.start() towards end of this method. lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (lines 117 - 130) <https://reviews.apache.org/r/51964/#comment223372> Does server start has to download/refresh jars upon every startup ? It would be expensive. and we are doing even if there are no changes to the files. Should we do size checks across local and remote filesystem before any copying? Put this enabled/disabled with a configuration? lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (lines 123 - 129) <https://reviews.apache.org/r/51964/#comment223373> This check has to happen before the above copy. lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 169) <https://reviews.apache.org/r/51964/#comment223374> not sure how its corresponding local jar file is added to classloader. If hdfs jar is getting added, it wont work. might have to pass the corresponding local jar as the location value for ResourceEntry. lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (line 213) <https://reviews.apache.org/r/51964/#comment223375> Can we store this at class level variable instead of reading from conf again and again ? lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java (lines 547 - 567) <https://reviews.apache.org/r/51964/#comment223376> We should not be filesystem close anywhere, FileSystem's shutdown hook will take care of it. lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java (line 339) <https://reviews.apache.org/r/51964/#comment223377> Why are we passing null name? We should remove the param, if it is not required anymore. lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java (line 310) <https://reviews.apache.org/r/51964/#comment223378> what is partial state here? I dont see any return with partial state. lens-server/src/main/resources/lensserver-default.xml (line 58) <https://reviews.apache.org/r/51964/#comment223379> Do we need this change? I see DatabaseResourceService is still getting added through SessionService. lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java (line 174) <https://reviews.apache.org/r/51964/#comment223380> Can you change logging style to slf4j parameterized style? - Amareshwari Sriramadasu On Oct. 25, 2016, 10:11 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51964/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 10:11 a.m.) > > > Review request for lens. > > > Bugs: LENS-317 > https://issues.apache.org/jira/browse/LENS-317 > > > Repository: lens > > > Description > ------- > > Server side api call to update database jar without restarting lens server. > More details can be found in LENS-317. > > > Diffs > ----- > > > lens-cli/src/main/java/org/apache/lens/cli/commands/LensDatabaseCommands.java > c6ae02b > lens-client/src/main/java/org/apache/lens/client/LensClient.java e936798 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > bb15b23 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server-api/src/main/java/org/apache/lens/server/api/session/SessionService.java > 20ec686 > lens-server/pom.xml d24dc1e > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 9d823da > > lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java > 511e4cf > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 21e2a62 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 34c901c > > lens-server/src/main/java/org/apache/lens/server/session/SessionResource.java > 63eea63 > lens-server/src/main/java/org/apache/lens/server/util/ScannedPaths.java > e48eab4 > lens-server/src/main/resources/lensserver-default.xml 8e5fe8a > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > 7cccf30 > lens-server/src/test/java/org/apache/lens/server/LensServerTestUtil.java > 67cee57 > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java > 2bc3712 > > lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseService.java > PRE-CREATION > lens-server/src/test/resources/lens-site.xml d96659f > pom.xml 4928c1f > > Diff: https://reviews.apache.org/r/51964/diff/ > > > Testing > ------- > > mvn clean install. > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [3.302s] > [INFO] Lens .............................................. SUCCESS [7.286s] > [INFO] Lens API .......................................... SUCCESS [31.546s] > [INFO] Lens API for server and extensions ................ SUCCESS [25.681s] > [INFO] Lens Cube ......................................... SUCCESS > [17:55.255s] > [INFO] Lens DB storage ................................... SUCCESS [25.650s] > [INFO] Lens Query Library ................................ SUCCESS [21.646s] > [INFO] Lens Hive Driver .................................. SUCCESS [2:11.167s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [1:03.464s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [54.798s] > [INFO] Lens Server ....................................... SUCCESS > [18:19.588s] > [INFO] Lens client ....................................... SUCCESS [2:02.590s] > [INFO] Lens CLI .......................................... SUCCESS [1:54.985s] > [INFO] Lens Examples ..................................... SUCCESS [13.790s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [2.061s] > [INFO] Lens Distribution ................................. SUCCESS [24.869s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:54.426s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [11.053s] > [INFO] Lens Regression ................................... SUCCESS [20.677s] > [INFO] Lens UI ........................................... SUCCESS [19.454s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 49:44.002s > [INFO] Finished at: Sat Sep 17 00:12:08 IST 2016 > [INFO] Final Memory: 178M/2490M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Sushil Mohanty > >
