----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52982/#review153861 -----------------------------------------------------------
lens-driver-hive/src/main/resources/hivedriver-default.xml (line 168) <https://reviews.apache.org/r/52982/#comment223388> Let's rename this as well to something like `retry.messages.contains.map`. lens-driver-hive/src/main/resources/hivedriver-default.xml (lines 174 - 175) <https://reviews.apache.org/r/52982/#comment223389> Class name change missed here lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml (line 273) <https://reviews.apache.org/r/52982/#comment223390> Class name change missed here lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java (line 45) <https://reviews.apache.org/r/52982/#comment223391> generics. `Map.Entry<String, Constructor>` lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java (lines 46 - 47) <https://reviews.apache.org/r/52982/#comment223392> Avoid cast by using generics lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java (lines 76 - 77) <https://reviews.apache.org/r/52982/#comment223393> Generics lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java (lines 82 - 84) <https://reviews.apache.org/r/52982/#comment223394> minor: https://docs.oracle.com/javase/7/docs/api/java/util/Arrays.html#fill(java.lang.Object[],%20java.lang.Object) - Rajat Khandelwal On Oct. 25, 2016, 6:08 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52982/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2016, 6:08 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > If any one of the configured messages are found then the retry will happen > > > Diffs > ----- > > lens-driver-hive/src/main/resources/hivedriver-default.xml f5fd3bb > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6 > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/FibonacciExponentialBackOffRetryHandler.java > 01da25d > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/ImmediateRetryHandler.java > c1c0126 > > lens-server-api/src/main/java/org/apache/lens/server/api/retry/SubstringMessagePolicyDecider.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/retry/TestSubStringMessagePolicyDecider.java > PRE-CREATION > src/site/apt/admin/hivedriver-config.apt b1a25c3 > src/site/apt/admin/jdbcdriver-config.apt c64d6ee > > Diff: https://reviews.apache.org/r/52982/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
