----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53217/#review154240 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java (line 218) <https://reviews.apache.org/r/53217/#comment223732> Can we add it to health status as well? Can we termintate queryExpirer when query service is stopped? Seems thread is not getting terminated now. lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 2016) <https://reviews.apache.org/r/53217/#comment223733> [Minor] typo in comment. instead of timeout value *1 second* to *300 millis* - Raju Bairishetti On Oct. 27, 2016, 9:04 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53217/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2016, 9:04 a.m.) > > > Review request for lens. > > > Bugs: LENS-968 > https://issues.apache.org/jira/browse/LENS-968 > > > Repository: lens > > > Description > ------- > > Adds configurable timeout for queries, which is overridable at driver level > and even at query level. > Adds a period checker which checks if any of queries timedout and canel them. > > > Diffs > ----- > > lens-driver-es/src/main/resources/esdriver-default.xml 5bd56b3 > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 89726c4 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 3ae59c6 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 64c7145 > > lens-server-api/src/test/java/org/apache/lens/server/api/driver/MockDriver.java > 2a2963f > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > b5e996f > lens-server/src/main/resources/lensserver-default.xml 8e5fe8a > lens-server/src/main/resources/lenssession-default.xml 9a8f9da > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 5a8d5e6 > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > ecbd689 > lens-server/src/test/resources/lens-site.xml d96659f > lens-server/src/test/resources/logback.xml 6b91a77 > src/site/apt/admin/config.apt f22fc0c > src/site/apt/admin/esdriver-config.apt ce952ae > src/site/apt/admin/jdbcdriver-config.apt c64d6ee > src/site/apt/admin/session-config.apt d480f88 > > Diff: https://reviews.apache.org/r/53217/diff/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.484s] > [INFO] Lens .............................................. SUCCESS [2.843s] > [INFO] Lens API .......................................... SUCCESS [21.049s] > [INFO] Lens API for server and extensions ................ SUCCESS [19.230s] > [INFO] Lens Cube ......................................... SUCCESS > [14:06.805s] > [INFO] Lens DB storage ................................... SUCCESS [16.439s] > [INFO] Lens Query Library ................................ SUCCESS [12.739s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:15.184s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [39.351s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [19.958s] > [INFO] Lens Server ....................................... SUCCESS > [16:28.932s] > [INFO] Lens client ....................................... SUCCESS [1:21.876s] > [INFO] Lens CLI .......................................... SUCCESS [1:12.501s] > [INFO] Lens Examples ..................................... SUCCESS [8.167s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.618s] > [INFO] Lens Distribution ................................. SUCCESS [8.981s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:02.132s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.106s] > [INFO] Lens Regression ................................... SUCCESS [12.315s] > [INFO] Lens UI ........................................... SUCCESS [30.001s] > [INFO] Lens Contrib ...................................... SUCCESS [0.328s] > [INFO] Lens Contributed Clients .......................... SUCCESS [0.325s] > [INFO] Lens Python Client ................................ SUCCESS [0.334s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 38:44.416s > [INFO] Finished at: Thu Oct 27 07:21:56 UTC 2016 > [INFO] Final Memory: 272M/3119M > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Amareshwari Sriramadasu > >