[ 
https://issues.apache.org/jira/browse/LENS-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628760#comment-15628760
 ] 

Amareshwari Sriramadasu commented on LENS-1342:
-----------------------------------------------

Finally there is one successful build - 
https://builds.apache.org/job/PreCommit-Lens-Build/1147/. We need to track 
other errors in pre-commit builds and close them to help simpler patches like 
this to get in faster.

> Unclosed InputStreamReader in PropertyBasedUserConfigLoader
> -----------------------------------------------------------
>
>                 Key: LENS-1342
>                 URL: https://issues.apache.org/jira/browse/LENS-1342
>             Project: Apache Lens
>          Issue Type: Bug
>            Reporter: Ted Yu
>            Priority: Minor
>         Attachments: 1342.v1.txt
>
>
> {code}
>     try {
>       properties.load(new InputStreamReader(new FileInputStream(new 
> File(filename)), "UTF-8"));
>     } catch (IOException e) {
>       throw new UserConfigLoaderException("property file not found. Provided 
> path was: " + filename);
>     }
> {code}
> The InputStreamReader should be closed upon return from the method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to