----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review162385 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (lines 225 - 226) <https://reviews.apache.org/r/55712/#comment233735> empty if? lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java (line 594) <https://reviews.apache.org/r/55712/#comment233736> Should we call it updatePeriodTableKey? lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (lines 664 - 668) <https://reviews.apache.org/r/55712/#comment233737> Can addPartition in CubeMetastoreClient access updatePeriod from partition spec to find final storage table, instead of creating a temp storage name? That would be cleaner. lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java (lines 685 - 697) <https://reviews.apache.org/r/55712/#comment233738> Same as above, can we move this cubemetastoreclient? lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java (line 867) <https://reviews.apache.org/r/55712/#comment233739> Changing storage name to updatePeriod_storage is looking more like a hack. - Amareshwari Sriramadasu On Jan. 19, 2017, 12:08 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 12:08 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > ------- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
