> On Jan. 24, 2017, 8:32 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 975 > > <https://reviews.apache.org/r/55715/diff/1/?file=1608972#file1608972line975> > > > > Can you add assert for actual messsage containing measure name as part > > of the message?
Added. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55715/#review162789 ----------------------------------------------------------- On Jan. 25, 2017, 6:29 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55715/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2017, 6:29 a.m.) > > > Review request for lens. > > > Bugs: LENS-1384 > https://issues.apache.org/jira/browse/LENS-1384 > > > Repository: lens > > > Description > ------- > > We can make the error message for the data completeness check less verbose. > New message can be something like - Requested metrics are only partially > complete. Partially complete metrics: <comma separated list of metrics>. Try > again later or remove metric and re-run report. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 2ad6e20 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > c9e7c29 > > Diff: https://reviews.apache.org/r/55715/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
