----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55712/#review165474 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 383) <https://reviews.apache.org/r/55712/#comment237325> If we are calling this for each updatePeriod separately even if the table is same for all updatePeriods, it can have huge impact on the time it takes to create timelines and requires huge memory to put all partitions. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java <https://reviews.apache.org/r/55712/#comment237326> no more required? what was it doing earlier which is not required now? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java (line 913) <https://reviews.apache.org/r/55712/#comment237327> Seems javadoc is wrong - Amareshwari Sriramadasu On Feb. 13, 2017, 6:47 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55712/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 6:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-1386 > https://issues.apache.org/jira/browse/LENS-1386 > > > Repository: lens > > > Description > ------- > > A new data structure XUpdatePeriodTableDescriptor is introduced which > contains an update period and table descriptor. Now the XUpdatePeriods will > contain a list of XUpdatePeriodTableDescriptor or XUpdatePeriod > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f438f48 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c92 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 6c9cde2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java cd9f705 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2a > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb43 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 0e6a4a1 > > Diff: https://reviews.apache.org/r/55712/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
