----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56842/#review167026 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 1081) <https://reviews.apache.org/r/56842/#comment239167> Is this needed ? lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java (line 1145) <https://reviews.apache.org/r/56842/#comment239168> Suggestion: The change form public to package access can be done is a separate review . This will make things harder to review in fanal patch. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 338) <https://reviews.apache.org/r/56842/#comment239169> This logic looks wrong. Pleas re-check. pom.xml (line 94) <https://reviews.apache.org/r/56842/#comment239163> Is this needed ? Can we do this separately if not mandatory for this patch. lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java (line 106) <https://reviews.apache.org/r/56842/#comment239164> Should we break the loop here ? - Puneet Gupta On Feb. 28, 2017, 7:59 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56842/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 7:59 a.m.) > > > Review request for lens. > > > Bugs: LENS-1389 > https://issues.apache.org/jira/browse/LENS-1389 > > > Repository: lens > > > Description > ------- > > This is causing test failure in lens-1381 branch. > > > Diffs > ----- > > checkstyle/src/main/resources/checkstyle-suppressions.xml PRE-CREATION > checkstyle/src/main/resources/suppressions.xml > 06c49af718e00485d39c06d4f3943a8c663da498 > lens-api/src/main/resources/cube-0.1.xsd > f438f48f252305ba6a3691b0a98b1f40eff1f25b > > lens-cube/src/main/java/org/apache/lens/cube/error/NoCandidateFactAvailableException.java > bdfa3a065bd24b507d26f3048dce42a58667be25 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > adb6c9277805805e2ca271667d660bff26fafca6 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > aa2e9d1a379f299c6acfd062e9061c5b959e2cd1 > lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java > 771708132a7e9dfbcb1148329647a946425b9d42 > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactPartition.java > 1694b8092e88fffcd3b96153cc1796bf3260df66 > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 53cf8af330c378eabc2da4ae88601227e0e21979 > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java > cd9f70552f2b5e463b490ec78de8384879eaf75c > lens-cube/src/main/java/org/apache/lens/cube/metadata/TimeRange.java > bf6cc5c3e6d8fc6521a5b0f1ef3e0212f0111c7a > > lens-cube/src/main/java/org/apache/lens/cube/parse/AbridgedTimeRangeWriter.java > 8681e90139e278e7e8f4489a162cf171edc98524 > > lens-cube/src/main/java/org/apache/lens/cube/parse/BetweenTimeRangeWriter.java > c8b81298aab87dcce23446e036a903095eb518da > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java > c36ce7097a8c3412ddaf23b4c08e0a0900a294c9 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTable.java > 5863c1ce1f8c6f55a27c09ae674a1cec2ad2a9b1 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047b57ebc26244891d9bc48ad18ab0176fdd > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > 2ab7f4bee68f05d46a625b50de90e07874d21b81 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > bdde27cd17af8e4fb50ad999692a3f928ab4d08a > lens-cube/src/main/java/org/apache/lens/cube/parse/CheckTableNames.java > 858626241df7347f138cd0a259530b31a39de3ab > > lens-cube/src/main/java/org/apache/lens/cube/parse/ColumnLifetimeChecker.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > e56193ccc311be38b2b5e03f5516c4c3bccd9e39 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryRewriter.java > f052a2fd9b2f02653502951a98efa3d4003b9e0a > > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeSemanticAnalyzer.java > fc960555c98d42bfbe7835c2edb24564449ba602 > > lens-cube/src/main/java/org/apache/lens/cube/parse/DenormalizationResolver.java > bb290346b23c6a2088cacd7834bc8a2a3e96fc07 > lens-cube/src/main/java/org/apache/lens/cube/parse/ExpressionResolver.java > 82113af4ea4f4ebf56712187389a8117aebeb595 > lens-cube/src/main/java/org/apache/lens/cube/parse/FieldValidator.java > 48af0c908fefdd331c2fe175292ff323a475735b > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde1786c2e6217a0d7aa7a26d1cc248bf532 > lens-cube/src/main/java/org/apache/lens/cube/parse/PruneCauses.java > 0c6465ac725b0b801a34818e114bbfdd065e972d > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueriedPhraseContext.java > 832b7a4894696e2e91fae398ac607405bdc9f3b2 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 3029589ae1db24330aebb6eaa34aa127c3576a04 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageUtil.java > 87f3ac23b67600b92592d93dc4c6bfa236b60120 > lens-cube/src/main/java/org/apache/lens/cube/parse/TimeRangeChecker.java > e37db8b78cda74b56b9983c25b972066c21340f6 > lens-cube/src/main/java/org/apache/lens/cube/parse/TrackDenormContext.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 8c81166de7d7293ea8754ba3391ea940424ad48f > > lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java > 9fecdbccbf188efd39d770662df3606cbf7d766e > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > e21dc2ac187318cbc52bd0e49cc8e7065236c4e0 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 194ab7c6c4cfc540933dbc00e2daac504b28c7e5 > > lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java > 1a5bd0d1f227c9cc9affadb4c79d2d337ac47706 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > 44847484d5558742be2ae7a0f4d62c6390f94977 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBetweenTimeRangeWriter.java > 450605b2fc6cf4e1962b17428705f3dfe805f43b > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > cf937a8644501c879598e4d16ef8477b5d44a408 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java > 15a8c383fff31e1b45aac85bf36189403372f251 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java > dd18ffd49a54e53e27fa7d31da3dee3ead6202db > lens-cube/src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java > f31156a133577a626707a56aa58a4914a65a8f88 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryMetrics.java > f9a54211cc602507fb48d571052881705461b863 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeResolver.java > d1a17b22a84eba825e24975b2ec82c17f2b334fe > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestTimeRangeWriterWithQuery.java > 09e09f8702008ff8bddb2277cc75b1ca45bb82e3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestUnionQueries.java > e41502ba0c6e40cc134a74fb9abe2270c29d91e2 > > lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java > 262d452a98fe5f9fd413014cf164b0c12e1dfd41 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java > 75153f669d5b45accb7e0ae52e854a685de8cae1 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/DruidSQLRewriter.java > 2351fb3428db8053d4c2508d09c0932de15731db > lens-examples/src/test/resources/yaml/city_table.yaml > 4f3b986912b5e8d8464e180d5b54f01e49cccaf9 > lens-examples/src/test/resources/yaml/customer_table.yaml > 2de5cd9124d6830b0bfa54629bec763a0e7bbaea > lens-examples/src/test/resources/yaml/dim_table.yaml > 8191456ad3ca5a94d104d4c2ee89da0097e0e54e > lens-examples/src/test/resources/yaml/dim_table2.yaml > 0df4682b23b047e6e42cc8f8d61063026117d33c > lens-examples/src/test/resources/yaml/dim_table4.yaml > f26c2cd5adab839cd7731d24da2a2ca09089ab6f > lens-examples/src/test/resources/yaml/fact1.yaml > c5c6d5737cd6790efed1df4baf02ad46948db31e > lens-examples/src/test/resources/yaml/fact2.yaml > 97112c877b3d937b01617e572fd6ba2f589b497a > lens-examples/src/test/resources/yaml/product_table.yaml > 54d37d81afcef34833947b5b3c6bc50d020a0ba8 > lens-examples/src/test/resources/yaml/rawfact.yaml > f7501925ac01c337c2f84781edeeddfee2ae3ad9 > lens-examples/src/test/resources/yaml/sales-aggr-continuous-fact.yaml > 0e98281d0b7505c503a252865e7bc7b516244c01 > lens-examples/src/test/resources/yaml/sales-aggr-fact1.yaml > 0be8cf245411cb0e7ccc107e5aa6687cedede10f > lens-examples/src/test/resources/yaml/sales-aggr-fact2.yaml > d1ba7fbd3462bc923a84b6087d403262ab4b8e29 > lens-examples/src/test/resources/yaml/sales-raw-fact.yaml > eaf7f155d9a460aa28074289ea485e80b26f9db3 > > lens-regression/src/main/java/org/apache/lens/regression/core/constants/DriverConfig.java > cff8e91cf255a20633477c526ec016606a3b14d7 > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ScheduleResourceHelper.java > f2883f07af6ba0ef93d83cd23105e6dc4f9f6ecc > > lens-regression/src/main/java/org/apache/lens/regression/util/AssertUtil.java > b04e420a75fddcbfddd40af068db122e134df235 > lens-regression/src/main/resources/template.lens.properties > 0df127d56600468ef7f96dc15f7c396621483fd1 > > lens-regression/src/test/java/org/apache/lens/regression/ITSessionTests.java > PRE-CREATION > lens-regression/src/test/java/org/apache/lens/regression/SessionTests.java > ce727a106b1b0e18e6a505e14bbc59339e04db92 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITDuplicateQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/ITKillQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/ITListQueryTest.java > cad2937be3eb7985e3392befa3b26bb980edaf17 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITPreparedQueryTests.java > fd73ba401f72daa9c1ce2ee484971198546c1027 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITQueryApiTests.java > 7b8b37716bae20256e9cf3eae0ccd5f73e3d2d99 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITScheduleQueryTests.java > 4e45c4cdc4ecb5e5373ce8d699867b412f7f9894 > > lens-regression/src/test/java/org/apache/lens/regression/client/ITSessionResourceTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/client/KillQueryTests.java > a39b2fe745487ae4d88e9b2f067be3562ae932d2 > > lens-regression/src/test/java/org/apache/lens/regression/client/SessionResourceTests.java > f6a10e82ced5d0deacc5167e4bb43a3cd40005c8 > > lens-regression/src/test/java/org/apache/lens/regression/config/ITServerConfigTests.java > 3503310ab15b6dca48fd61037e07a19efa0bda17 > > lens-regression/src/test/java/org/apache/lens/regression/config/ITSessionConfigTests.java > 2deb043668b06c5685f8a1f41b7e430d2159ec23 > > lens-regression/src/test/java/org/apache/lens/regression/scheduler/ITMaxScheduledQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/scheduler/ITScheduleQueryTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/throttling/ITCostTests.java > aeae8aa820da381e9067cc965d44459a85010acd > > lens-regression/src/test/java/org/apache/lens/regression/throttling/ITQueueNumberTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/throttling/ITThrottlingTests.java > PRE-CREATION > > lens-regression/src/test/java/org/apache/lens/regression/throttling/Throttling.java > abf72638d150d9f268859cebcae7eacee5d39dac > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 8b10d1d6ba7b39474065a2dbfbf1002f9b29151e > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 51fcb4390b9de4ad721be1b3ade176b3487ba7ac > lens-server/src/main/java/org/apache/lens/server/query/LensServerDAO.java > dd489e8895560cc3bedd92bffe823dc45c63a159 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c76ad243ff73aa3dda6d4de62e477abddc9630a1 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 21e2a629164f81642bd48d670345bf98aa46125c > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 34c901cdda98770fb4ca47fc2b0be5ce36dacff9 > lens-server/src/main/resources/lensserver-default.xml > 261fa5248068e406f12a3185145d5b0e23fdac48 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 0e6a4a1dffbbd2d8331b601e2c4dec745a63fb7d > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java > 8c1bb7ba43b85f2726014d848f6d06f665277455 > pom.xml 8ea64b77fff11d9f46be56437aed3b527bde0ff8 > src/site/apt/admin/config.apt eb35ae3b06e7c3a7d22697f540e3198497510d9c > tools/conf/server/logback.xml 63ab23c70bcf6f3ed8303da6a02eb930dc4fcc2c > > Diff: https://reviews.apache.org/r/56842/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >