> On March 7, 2017, 11:14 a.m., Amareshwari Sriramadasu wrote: > > Can we include a regression test which fails without the fix?
Yes. Testcase will be added once the testcases in TestUnionQueries are fixed as suggested by Puneet. I have opened another jira to track the same : LENS-1402 - Rajitha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57366/#review168113 ----------------------------------------------------------- On March 7, 2017, 10:01 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57366/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 10:01 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > The Unionquerywriter has a bug where it defaults the measure values to zero > if the definition of the measure has dimensions involved. This is a fix for > the same. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 4f1f808 > > > Diff: https://reviews.apache.org/r/57366/diff/1/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
