> On March 22, 2017, 5:44 p.m., Sushil Mohanty wrote: > >
Overview: 1. xml changes: this means lot of code removal from cubetestsetup and addition of a lot of xml files 2. To create from xml in cube tests, I need the ability to read xml files in cube module. So moved jaxbutils to cube modle 3. Cubemetastoreserviceimpl(server) was using jaxbutils, so some of those functions now moved to CubeMetastoreClient. 4. So cubemetastoreclient now has wrapper functions like `create(XCube c) == create(jaxbutils.cubeFromXCube(c))` 5. Also added one general `create` function that takes file path and `Class<entity type>` 6. Wanted to reused the directory structure restrictions of `create schema` cli command 7. So abstracted out a `SchemaDirectoryTraverser` in `api` module and implemented `LensSchemaCommands` using this 8. Used `SchemaDirectoryTraverser` along with the general function mentioned in (5) to create entities in `CubeTestSetup` > On March 22, 2017, 5:44 p.m., Sushil Mohanty wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > > Lines 349 (patched) > > <https://reviews.apache.org/r/57418/diff/4/?file=1659916#file1659916line349> > > > > This method already present in CubeMetastoreServiceImpl, can we resue > > this? Yes, this is now moved from service to client. > On March 22, 2017, 5:44 p.m., Sushil Mohanty wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > > Lines 53 (patched) > > <https://reviews.apache.org/r/57418/diff/4/?file=1659917#file1659917line53> > > > > Looks like this the same class present in > > org.apache.lens.server.metastore. Can't we import the static methods and > > reuse instead of creating a copy of the class. Class also moved from server to cube module - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57418/#review169695 ----------------------------------------------------------- On March 9, 2017, 4:58 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57418/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 4:58 p.m.) > > > Review request for lens. > > > Bugs: LENS-1400 > https://issues.apache.org/jira/browse/LENS-1400 > > > Repository: lens > > > Description > ------- > > To add more tests in cube module, one would need to create more schema > objects. Creating them in java is too difficult and hard to read for other > people. So I'll be converting them to xml based schema creation. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/ToXMLString.java > e74adc9a7289233876b2f3a1ad2f365a7466b65b > lens-api/src/main/java/org/apache/lens/api/jaxb/LensJAXBContext.java > 14fc4aa19a30e81863d0386734886d5258203e4b > lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java > PRE-CREATION > lens-api/src/main/resources/cube-0.1.xsd > 060eb43c6d73e5f3780ab5915cb12b26a41a44af > lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java > feabf9c221fdcfb551aff7e6b80fba484133846e > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 896a7a1a3fafc1d4e49bc8cef08b22cb3712d245 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 78fb6d3a49ec7c5d407267d835bdfc83a6fd0cc2 > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 25acb01a94b4103806eccac539d16bc1b12761dd > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > bc008ae6181490909605488a618029b8b6086f3c > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 94d4b40ee33fc8c81904d5979bc6cc8cfe599e24 > lens-cube/src/test/resources/schema/cubes/base/basecube.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/base/testcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/derived/der1.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/derived/der2.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/derived/der3.xml PRE-CREATION > lens-cube/src/test/resources/schema/cubes/derived/derivedcube.xml > PRE-CREATION > lens-cube/src/test/resources/schema/cubes/derived/union_join_ctx_der1.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/citydim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/countrydim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/cycledim1.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/cycledim2.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/daydim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/hourdim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/sports.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/statedim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/testdim2.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/testdim3.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/testdim4.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/unreachabledim.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/user_interests.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/userdim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimensions/zipdim.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/citytable.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/citytable2.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/citytable3.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/citytable4.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/countrytable.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/countrytable_partitioned.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/cycledim1tbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/cycledim2tbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/daydimtbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/hourdimtbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/sports_tbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/statetable.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/statetable_partitioned.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/testdim2tbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/testdim2tbl2.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/testdim2tbl3.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/testdim3tbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/testdim4tbl.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/unreachabledimtable.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/user_interests_tbl.xml > PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/usertable.xml PRE-CREATION > lens-cube/src/test/resources/schema/dimtables/ziptable.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/cheapfact.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/summary1.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/summary2.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/summary3.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/summary4.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact1_base.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact1_raw_base.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact2.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact2_base.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact2_raw.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact2_raw_base.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact3_base.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact3_raw_base.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact4_raw_base.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact5_base.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact5_raw_base.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact6_base.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact_continuous.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfact_deprecated.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/testfactmonthly.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/union_join_ctx_fact1.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/union_join_ctx_fact2.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/union_join_ctx_fact3.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/union_join_ctx_fact5.xml > PRE-CREATION > lens-cube/src/test/resources/schema/facts/union_join_ctx_fact6.xml > PRE-CREATION > lens-cube/src/test/resources/schema/segmentations/seg1.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c0.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c1.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c2.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c3.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c4.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c5.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c99.xml PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 24660e193a59fe7589de3147e412a08a0a22814e > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 7d54c7b2c5471851a0d4049ba1a84a8d396e0ca2 > > > Diff: https://reviews.apache.org/r/57418/diff/4/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
