-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58956/
-----------------------------------------------------------
(Updated May 4, 2017, 5:45 p.m.)
Review request for lens.
Bugs: LENS-1417
https://issues.apache.org/jira/browse/LENS-1417
Repository: lens
Description
-------
create schema command is useful but it calls create/update for all the schema
xml files. The following things will be useful:
* Option to specify entity type filter. e.g. create only cubes
* Option to specify file name filter. e.g. create only entities having `x` in
their names
* Reporting all Failures collectively at the end.
The general flow in cli is to run a command, then for subsequent runs of the
same command, one generally tends to use the command history and modify
existing commands. So although there already exists a way to solve for point 2,
but it involves writing another command. Having this filter will be helpful.
Diffs (updated)
-----
lens-api/src/main/java/org/apache/lens/api/metastore/SchemaTraverser.java
76cb8b90e206eea076cf32b87d97617a833c3f91
lens-cli/src/main/java/org/apache/lens/cli/commands/LensSchemaCommands.java
60bd9e074848c8579f1ad4edcd8e4873f40c4843
lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java
cdd101bfa4b6ce77492e1626491e58e570be03af
Diff: https://reviews.apache.org/r/58956/diff/3/
Changes: https://reviews.apache.org/r/58956/diff/2-3/
Testing
-------
Thanks,
Rajat Khandelwal
