----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59714/#review176900 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java Lines 359 (patched) <https://reviews.apache.org/r/59714/#comment250441> Should we rename the method to decideMeasurePhraseToAnswer and parameter to measurePhraseIndices ? Also please add method level comments lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java Lines 833 (patched) <https://reviews.apache.org/r/59714/#comment250442> Can we leave a comment in code why this is needed. - Puneet Gupta On June 1, 2017, 12:51 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59714/ > ----------------------------------------------------------- > > (Updated June 1, 2017, 12:51 p.m.) > > > Review request for lens. > > > Bugs: LENS-1428 > https://issues.apache.org/jira/browse/LENS-1428 > > > Repository: lens > > > Description > ------- > > For JoinCandidate if a measure is answerable by its children, getting > projected in both. Instead the measure should be projected in one of the > children and default measure i.e 0.0 for the other. > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/parse/Candidate.java 9f07336 > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryContext.java > 47bce65 > lens-cube/src/main/java/org/apache/lens/cube/parse/JoinCandidate.java > 038d689 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > lens-cube/src/main/java/org/apache/lens/cube/parse/UnionQueryWriter.java > 6c0d91a > > > Diff: https://reviews.apache.org/r/59714/diff/1/ > > > Testing > ------- > > > Thanks, > > Sushil Mohanty > >
