----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60654/ -----------------------------------------------------------
(Updated July 5, 2017, 12:01 p.m.) Review request for lens and Amareshwari Sriramadasu. Changes ------- Review comment: Adding missing @Test Repository: lens Description ------- This property is currently set at lens level. we need to be able to set it at driver level. Lens-site.xml or session conf will override driver conf and in driver, it needs to be set with final = true Diffs (updated) ----- lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java 8e431d1 lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java 9923589 lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java 1149696 lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java 4f8b8ff lens-server/src/test/resources/drivers/hive/hive1/hivedriver-site.xml 1f0ff43 lens-server/src/test/resources/drivers/hive/hive2/hivedriver-site.xml eb902e0 lens-server/src/test/resources/drivers/jdbc/jdbc1/jdbcdriver-site.xml 5b8b43f lens-server/src/test/resources/lens-site.xml 0060fa7 Diff: https://reviews.apache.org/r/60654/diff/2/ Changes: https://reviews.apache.org/r/60654/diff/1-2/ Testing ------- Added UT for this feature:- TestResultFormatting.testResultDirOverrideFromDriverConf() [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary: [INFO] [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 15.593 s] [INFO] Lens ............................................... SUCCESS [ 27.498 s] [INFO] Lens API ........................................... SUCCESS [01:05 min] [INFO] Lens API for server and extensions ................. SUCCESS [ 54.682 s] [INFO] Lens Cube .......................................... SUCCESS [02:06 min] [INFO] Lens DB storage .................................... SUCCESS [ 33.767 s] [INFO] Lens Query Library ................................. SUCCESS [ 22.014 s] [INFO] Lens Hive Driver ................................... SUCCESS [ 35.184 s] [INFO] Lens Driver for JDBC ............................... SUCCESS [ 34.841 s] [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 30.747 s] [INFO] Lens Server ........................................ SUCCESS [03:08 min] [INFO] Lens client ........................................ SUCCESS [ 38.710 s] [INFO] Lens CLI ........................................... SUCCESS [ 44.817 s] [INFO] Lens Examples ...................................... SUCCESS [ 16.831 s] [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 4.019 s] [INFO] Lens Distribution .................................. SUCCESS [ 48.381 s] [INFO] Lens ML Lib ........................................ SUCCESS [ 52.241 s] [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 25.657 s] [INFO] Lens Regression .................................... SUCCESS [ 41.890 s] [INFO] Lens UI ............................................ SUCCESS [ 23.022 s] [INFO] Lens Contrib ....................................... SUCCESS [ 0.547 s] [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.427 s] [INFO] Lens Python Client ................................. SUCCESS [ 0.532 s] [INFO] ------------------------------------------------------------------------ Thanks, Raghavendra Singh
