----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61812/#review183707 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Aug. 22, 2017, 12:56 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61812/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2017, 12:56 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Repository: lens > > > Description > ------- > > Valid columns addition in virtual fact > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > 1fc74b0 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestVirtualFactQueries.java > 4bcb376 > lens-cube/src/test/resources/schema/cubes/base/testcube2.xml 9740e00 > lens-cube/src/test/resources/schema/facts/testfact9_base.xml 56e5746 > lens-cube/src/test/resources/schema/facts/virtual/virtualfact.xml 13f6773 > > > Diff: https://reviews.apache.org/r/61812/diff/2/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
