> On Aug. 29, 2017, 10:26 a.m., Puneet Gupta wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > > Lines 937 (patched) > > <https://reviews.apache.org/r/61938/diff/1/?file=1806054#file1806054line937> > > > > We should make sure participatingUpdatePeriods does not have any update > > period that has zero partitions. Should line 536 " > > this.participatingUpdatePeriods.add(maxInterval);" be deleted ? > > Rajitha R wrote: > I tried do to this but test cases started failing. > > Puneet Gupta wrote: > <p>Lets check this further.</p>
Done with the changes and validated the test cases as well - Rajitha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61938/#review184040 ----------------------------------------------------------- On Aug. 30, 2017, 3:11 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61938/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2017, 3:11 p.m.) > > > Review request for lens, Amareshwari Sriramadasu and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Fix for time_range_in clause not resolving in rewrite > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 2b1add3 > lens-cube/src/test/java/org/apache/lens/cube/metadata/DateFactory.java > 855f54a > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0366e56 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > bc0fa2e > lens-cube/src/test/resources/schema/cubes/base/testcube.xml 9d2bb02 > lens-cube/src/test/resources/schema/facts/summary5.xml PRE-CREATION > lens-cube/src/test/resources/schema/storages/c98.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/61938/diff/2/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
