> On Dec. 27, 2017, 11:51 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > > Lines 234 (patched) > > <https://reviews.apache.org/r/64779/diff/2/?file=1926175#file1926175line234> > > > > should we return or add the missing user to SESSION_USER_INSTANCE_MAP ?
The user is added to this map in the same method before this call..so this can be called a redundant check > On Dec. 27, 2017, 11:51 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > > Line 342 (original), 349 (patched) > > <https://reviews.apache.org/r/64779/diff/2/?file=1926175#file1926175line349> > > > > Is this inconsistnecy coming due to a restart ? Can we handle this on > > restart itself in that case when session service boots up When the system boots up, this map is correctly being updated. Confirming that from the code. This issue seems to occur when there are active sessions(session map non empty) while sessions per user map being empty. This could have happened when multiple threads are trying to update the sessions per user map which doesn't have any synchronization. I have handled the same in the updatesessioncount method above. - Rajitha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64779/#review194536 ----------------------------------------------------------- On Dec. 21, 2017, 3:40 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64779/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 3:40 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1497 > https://issues.apache.org/jira/browse/LENS-1497 > > > Repository: lens > > > Description > ------- > > NPE fix in closing idle connections > > > Diffs > ----- > > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > d7ce434 > > > Diff: https://reviews.apache.org/r/64779/diff/2/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
