----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66081/#review199570 -----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 34 (patched) <https://reviews.apache.org/r/66081/#comment279889> added. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 36 (patched) <https://reviews.apache.org/r/66081/#comment279888> If we try to extend RetryingThriftCLIServiceClient then it forces us to override all member functions since we cant access private data members of base class in derived class. we are doing it now anyhow but invokeInternal in base class refer to inner protected class "InvocationResult" if we try to overide invokeinternal then we are force to use "InvocationResult" in our implementation. since this class is inner protected class it cant be accessed from outside the class. This problem can be solved by extending InvocationResult. This require initialising base class in derived class's constructor causing same issue of not been able to use class outside package. lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 37-42 (patched) <https://reviews.apache.org/r/66081/#comment279890> added lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 44 (patched) <https://reviews.apache.org/r/66081/#comment279891> removed lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 51 (patched) <https://reviews.apache.org/r/66081/#comment279892> made it private lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 61 (patched) <https://reviews.apache.org/r/66081/#comment279893> added this lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 68 (patched) <https://reviews.apache.org/r/66081/#comment279894> made it private lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 88 (patched) <https://reviews.apache.org/r/66081/#comment279895> made it private lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 116 (patched) <https://reviews.apache.org/r/66081/#comment279896> corrected lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java Lines 120 (patched) <https://reviews.apache.org/r/66081/#comment279897> added lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java Lines 722 (patched) <https://reviews.apache.org/r/66081/#comment279898> corrected lens-server/src/main/java/org/apache/lens/server/BaseLensService.java Lines 177 (patched) <https://reviews.apache.org/r/66081/#comment279878> yes.. lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java Lines 578 (patched) <https://reviews.apache.org/r/66081/#comment279899> added - Ankit Kailaswar On March 20, 2018, 10:27 a.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66081/ > ----------------------------------------------------------- > > (Updated March 20, 2018, 10:27 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Rajat Khandelwal, and > Puneet Gupta. > > > Repository: lens > > > Description > ------- > > https://issues.apache.org/jira/browse/LENS-1506 > > This patch contains code changes to enable kerberos authentication for > 1. lens to hive > 2. lens to metastore > 3. lens to hdfs > > code changes are as follows, > 1. new http thrift client for hive driver to support sasl transport for > kerberozied hive server. > 2. cron to update KDC ticket before it expires. > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 2eb94aa > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RemoteThriftConnection.java > 54885f7 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/RetryingThriftCLIServiceClientSasl.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > d5273be > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > b9fcdd8 > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 31ac358 > > > Diff: https://reviews.apache.org/r/66081/diff/1/ > > > Testing > ------- > > unit testing > > > Thanks, > > Ankit Kailaswar > >
