----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67432/#review204246 -----------------------------------------------------------
Ship it! Ship It! - Rajat Khandelwal On June 4, 2018, 2:42 p.m., Ankit Kailaswar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67432/ > ----------------------------------------------------------- > > (Updated June 4, 2018, 2:42 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Fix of urlparse import in auth.py to make compatibiliy with Python 2 and 3. > Jira : https://issues.apache.org/jira/browse/LENS-1517 > And > Fir for ignore cert variable in query.py > Jira : https://issues.apache.org/jira/browse/LENS-1518 > > > Diffs > ----- > > contrib/clients/python/lens/client/auth.py fccc75c9 > contrib/clients/python/lens/client/query.py 8b0616b6 > contrib/clients/python/setup.py 5c64067e > > > Diff: https://reviews.apache.org/r/67432/diff/1/ > > > Testing > ------- > > Tested with Python 2.7.12 and Python 3.5.2 by Michael McCarthy for Lens-1517. > Tested with Python 2.7 for Lens-1518 and queried on self signed and ca signed > cert. > > > Thanks, > > Ankit Kailaswar > >
