----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68471/#review208346 -----------------------------------------------------------
Ship it! Ship It! - Ankit Kailaswar On Aug. 22, 2018, 10:27 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68471/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2018, 10:27 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > The current isAuthorized call in AuthorizationUtil is checking for session > related configuration from service conf which should rather be session conf. > This leads to incorrect session params being read for different sessions > causing authorization failures > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/authorization/AuthorizationUtil.java > ccd46a3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e6afcff > > lens-cube/src/main/java/org/apache/lens/cube/parse/QueryAuthorizationResolver.java > 78dd642 > > > Diff: https://reviews.apache.org/r/68471/diff/2/ > > > Testing > ------- > > [INFO] > [INFO] Lens Checkstyle Rules .............................. SUCCESS [ 2.734 > s] > [INFO] Lens ............................................... SUCCESS [ 5.553 > s] > [INFO] Lens API ........................................... SUCCESS [ 28.035 > s] > [INFO] Lens API for server and extensions ................. SUCCESS [ 25.289 > s] > [INFO] Lens Cube .......................................... SUCCESS [08:06 > min] > [INFO] Lens DB storage .................................... SUCCESS [ 33.949 > s] > [INFO] Lens Query Library ................................. SUCCESS [ 16.945 > s] > [INFO] Lens Hive Driver ................................... SUCCESS [01:57 > min] > [INFO] Lens Driver for JDBC ............................... SUCCESS [01:11 > min] > [INFO] Lens Elastic Search Driver ......................... SUCCESS [ 40.179 > s] > [INFO] Lens Server ........................................ SUCCESS [13:02 > min] > [INFO] Lens client ........................................ SUCCESS [02:09 > min] > [INFO] Lens CLI ........................................... SUCCESS [02:14 > min] > [INFO] Lens Examples ...................................... SUCCESS [ 12.243 > s] > [INFO] Lens Ship Jars to Distributed Cache ................ SUCCESS [ 2.325 > s] > [INFO] Lens Distribution .................................. SUCCESS [ 22.174 > s] > [INFO] Lens ML Lib ........................................ SUCCESS [01:52 > min] > [INFO] Lens ML Ext Distribution ........................... SUCCESS [ 4.972 > s] > [INFO] Lens Regression .................................... SUCCESS [ 14.733 > s] > [INFO] Lens UI ............................................ SUCCESS [ 6.186 > s] > [INFO] Lens Contrib ....................................... SUCCESS [ 0.438 > s] > [INFO] Lens Contributed Clients ........................... SUCCESS [ 0.347 > s] > [INFO] Lens Python Client ................................. SUCCESS [ 0.543 > s] > [INFO] > ------------------------------------------------------------------------ > [INFO] BUILD SUCCESS > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 34:11 min > [INFO] Finished at: 2018-08-22T16:46:43+05:30 > [INFO] Final Memory: 269M/1572M > > > Thanks, > > Rajitha R > >
