[ 
https://issues.apache.org/jira/browse/LENS-1543?focusedWorklogId=227265&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-227265
 ]

ASF GitHub Bot logged work on LENS-1543:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Apr/19 01:34
            Start Date: 14/Apr/19 01:34
    Worklog Time Spent: 10m 
      Work Description: bd2019us commented on pull request #33: [LENS-1543] fix 
replaceAll() to replace() to improve performance
URL: https://github.com/apache/lens/pull/33
 
 
   Fix Issue [#LENS-1543](https://issues.apache.org/jira/browse/LENS-1543)
   The replaceAll() method will compile the given regular expression ahead of 
time even though the given string is simply a plain string, which will have a 
bad performance. At this time, the replace() method is recommended to gain a 
good performance.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 227265)
            Time Spent: 10m
    Remaining Estimate: 0h

> change String.replaceAll() to replace() to improve performance.
> ---------------------------------------------------------------
>
>                 Key: LENS-1543
>                 URL: https://issues.apache.org/jira/browse/LENS-1543
>             Project: Apache Lens
>          Issue Type: Bug
>          Components: cube
>            Reporter: bd2019us
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Location: lens-cube/src/main/java/org/apache/lens/cube/metadata/DateUtil.java
> Since the string to be replaced is not complicated regular expression, the 
> other one (String.replace()) is recommended as it is more efficient than 
> replaceAll() without pre-compiling.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to