[
https://issues.apache.org/jira/browse/LENS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Rajat Khandelwal updated LENS-50:
---------------------------------
Attachment: LENS-50.0.patch
Remaining checkstyle violations:
{noformat}
src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java:101:3:
Definition of 'equals()' without corresponding definition of 'hashCode()'.
src/main/java/org/apache/lens/cube/metadata/AbstractBaseTable.java:39:42: Name
'columns' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
src/main/java/org/apache/lens/cube/metadata/ColumnMeasure.java:36:10: More than
7 parameters.
src/main/java/org/apache/lens/cube/metadata/ColumnMeasure.java:41:10: More than
7 parameters.
src/main/java/org/apache/lens/cube/metadata/Cube.java:178:3: Definition of
'equals()' without corresponding definition of 'hashCode()'.
src/main/java/org/apache/lens/cube/metadata/Cube.java:43: Line is longer than
120 characters.
src/main/java/org/apache/lens/cube/metadata/CubeDimensionTable.java:135:3:
Definition of 'equals()' without corresponding definition of 'hashCode()'.
src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java:116:3:
Definition of 'equals()' without corresponding definition of 'hashCode()'.
src/main/java/org/apache/lens/cube/metadata/CubeMeasure.java:35:13: More than 7
parameters.
src/main/java/org/apache/lens/cube/metadata/DerivedCube.java:142:3: Definition
of 'equals()' without corresponding definition of 'hashCode()'.
src/main/java/org/apache/lens/cube/metadata/Dimension.java:122:3: Definition of
'equals()' without corresponding definition of 'hashCode()'.
src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java:21:
interfaces should describe a type and hence have methods.
src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java:33:1: Utility
classes should not have a public or default constructor.
src/main/java/org/apache/lens/cube/metadata/StorageConstants.java:27:1: Utility
classes should not have a public or default constructor.
src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java:31:1: Utility
classes should not have a public or default constructor.
src/main/java/org/apache/lens/cube/parse/DimHQLContext.java:44:3: More than 7
parameters.
src/main/java/org/apache/lens/cube/parse/HQLParser.java:98:1: Utility classes
should not have a public or default constructor.
src/main/java/org/apache/lens/cube/parse/JoinResolver.java:117:12: More than 7
parameters.
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:133:33: '||'
should be on a new line.
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:144: case
child at indentation level 6 not at correct indentation, 4
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:145: if at
indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:147: if
child at indentation level 10 not at correct indentation, 8
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:148: if
rcurly at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:149: block
child at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:150: block
child at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:151: case
child at indentation level 6 not at correct indentation, 4
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:152: if at
indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:154: if
child at indentation level 10 not at correct indentation, 8
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:155: if
rcurly at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:156: block
child at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:157: block
child at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:158: case
child at indentation level 6 not at correct indentation, 4
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:159: block
child at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:160: block
child at indentation level 8 not at correct indentation, 6
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:296:24:
Inner assignments should be avoided.
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:444: method
def throws at indentation level 6 not at correct indentation, 4
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:454:19: More
than 7 parameters.
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:457: method
def throws at indentation level 6 not at correct indentation, 4
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:62:22: Name
'LOG' must match pattern '^[a-z][a-zA-Z0-9]*$'.
src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java:632: method
call child at indentation level 10 not at correct indentation, 12
src/main/java/org/apache/lens/cube/parse/StorageUtil.java:31:1: Utility classes
should not have a public or default constructor.
src/main/java/org/apache/lens/cube/parse/TimeRangeUtils.java:21:1: Utility
classes should not have a public or default constructor.
src/main/java/org/apache/lens/driver/cube/RewriteUtil.java:44:1: Utility
classes should not have a public or default constructor.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:101:24: Name
'MONTH_FMT' must match pattern '^[a-z][a-zA-Z0-9]*$'.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:101:24: Variable
'MONTH_FMT' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:112:22: Variable
'now' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:113:22: Variable
'twodaysBack' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:114:22: Variable
'oneDayBack' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:115:24: Variable
'twoDaysRange' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:116:22: Variable
'twoMonthsBack' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:117:24: Variable
'twoMonthsRangeUptoMonth' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:118:24: Variable
'twoMonthsRangeUptoHours' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:119:24: Variable
'twoDaysRangeBefore4days' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:120:22: Variable
'before4daysStart' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:121:22: Variable
'before4daysEnd' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:334: Line is longer
than 120 characters.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:99:24: Name
'HOUR_FMT' must match pattern '^[a-z][a-zA-Z0-9]*$'.
src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java:99:24: Variable
'HOUR_FMT' must be private and have accessor methods.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:1145: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:1161: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:248: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:358: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:366: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:375: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:476: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:47:1: Redundant
import from the same package - org.apache.lens.cube.parse.CubeQueryConfUtil.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:48:1: Redundant
import from the same package - org.apache.lens.cube.parse.CubeQueryContext.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:49:1: Redundant
import from the same package - org.apache.lens.cube.parse.CubeQueryRewriter.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:50:1: Redundant
import from the same package - org.apache.lens.cube.parse.HQLParser.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:51:1: Redundant
import from the same package - org.apache.lens.cube.parse.StorageUtil.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:670: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:671: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:672: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:674: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:675: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:676: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:677: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:678: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:679: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:680: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:681: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:682: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:687: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:689: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:690: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:691: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:692: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:693: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:694: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:695: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:696: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:697: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:698: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:737: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:738: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:743: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:744: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:810: Line is
longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:989:19: Array
brackets at illegal position.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:990: array
initialization lcurly at indentation level 8 not at correct indentation, 4
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:991: array
initialization child at indentation level 12 not at correct indentation, 6
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:992: array
initialization child at indentation level 12 not at correct indentation, 6
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:993: array
initialization child at indentation level 12 not at correct indentation, 6
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:994: Array
should contain trailing comma.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:996:27: Array
brackets at illegal position.
src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java:997: array
initialization lcurly at indentation level 8 not at correct indentation, 4
src/test/java/org/apache/lens/cube/parse/TestDenormalizationResolver.java:80:
Line is longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java:162: Line
is longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java:276: Line
is longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestExpressionResolver.java:289: Line
is longer than 120 characters.
src/test/java/org/apache/lens/cube/parse/TestJoinResolver.java:222:37: Empty
catch block.
src/test/java/org/apache/lens/driver/cube/TestRewriting.java:266: Line is
longer than 120 characters.
src/test/java/org/apache/lens/driver/cube/TestRewriting.java:346: Line is
longer than 120 characters.
src/test/java/org/apache/lens/driver/cube/TestRewriting.java:42:8: Unused
import - org.powermock.modules.testng.PowerMockObjectFactory.
{noformat}
> Checkstyle related changes on lens-cube
> ---------------------------------------
>
> Key: LENS-50
> URL: https://issues.apache.org/jira/browse/LENS-50
> Project: Apache Lens
> Issue Type: Sub-task
> Components: cube
> Affects Versions: 2.0
> Reporter: Rajat Khandelwal
> Assignee: Rajat Khandelwal
> Fix For: 2.0
>
> Attachments: LENS-50.0.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
