[
https://issues.apache.org/jira/browse/LENS-57?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14227239#comment-14227239
]
Amareshwari Sriramadasu commented on LENS-57:
---------------------------------------------
Some minor comments on the patch :
bq. + //cubeql.addOptionalDimTable(rel.getFromTable().getName(), null,
null, required);
Can you remove the commented code?
bq. + private boolean trimLongerPaths = false;
Is the flag required any more? Can it be just removed?
Can you also update test result here?
> Separate in and out edges in SchemaGraph
> ----------------------------------------
>
> Key: LENS-57
> URL: https://issues.apache.org/jira/browse/LENS-57
> Project: Apache Lens
> Issue Type: Sub-task
> Components: cube
> Reporter: Amareshwari Sriramadasu
> Assignee: Rajat Khandelwal
> Fix For: 2.0
>
> Attachments: LENS-57.1.patch, LENS-57.WIP.patch, LENS-57.patch
>
>
> Right now SchemaGraph contains both in-edge and out-edge as same relation.
> This causes issues by making unreachable paths also reachable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
