> On Dec. 15, 2014, 8:59 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java, > > line 790 > > <https://reviews.apache.org/r/29035/diff/1/?file=791618#file791618line790> > > > > This is right now causing the entry for query being lost.We should look > > at the cause of exception and accordingly do retries or drop.If it is a > > valid db issue, then we end dropping all query entries.
In the code we can't know right know what problems might be occuring. We can just increment error counters etc and hope those are looked at frequently. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29035/#review65078 ----------------------------------------------------------- On Dec. 24, 2014, 12:47 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29035/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2014, 12:47 p.m.) > > > Review request for lens. > > > Bugs: LENS-120 > https://issues.apache.org/jira/browse/LENS-120 > > > Repository: lens > > > Description > ------- > > QueryPurger Should retry with a timeout if db connection is not working. Also > There should be a limit to number of timeouts > > > Diffs > ----- > > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 0ae539e > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryPurgeFailed.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 9521136 > > Diff: https://reviews.apache.org/r/29035/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
