[ 
https://issues.apache.org/jira/browse/LENS-163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Srikanth Sundarrajan updated LENS-163:
--------------------------------------
    Attachment: LENS-163-v3.patch

Changes in this patch.

1. Move fs::close() to LensServices::stop()
2. Move buildnumber plugin version to a property
3. Use fs::newInstance() to get persistenceFS and cache this in LensServices

> Fix Lens Server & Stop related issues. Was (Proprietary classes referenced in 
> LensServer)
> -----------------------------------------------------------------------------------------
>
>                 Key: LENS-163
>                 URL: https://issues.apache.org/jira/browse/LENS-163
>             Project: Apache Lens
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 2.0
>            Reporter: Srikanth Sundarrajan
>            Assignee: Srikanth Sundarrajan
>             Fix For: 2.0
>
>         Attachments: LENS-163-v1.patch, LENS-163-v2.patch, LENS-163-v3.patch, 
> LENS-163.movestoptomain.patch, LENS-163.patch
>
>
> LensServer imports the following dependencies
> {code}
> import sun.misc.Signal;
> import sun.misc.SignalHandler;
> {code}
> and this is being used to register essentially shutdownhook.
> {code}
> ...
>     Signal.handle(new Signal("TERM"), new SignalHandler() {
>       @Override
>       public void handle(Signal signal) {
> ...
> {code}
> We should use Runtime::addShutdownHook() instead.
> Besides issues reported relating to proprietary class references, there are 
> other issues in how start & stop are handled. Broadening the scope of this 
> issue based on feedback from [~jaideepdhok] and laxman



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to