> On Jan. 20, 2015, 7:10 a.m., Amareshwari Sriramadasu wrote: > > bq. Need to add automatic calls when updation of dims/facts is called. > > Altering tables automatically updates cache and we would not require any of > > this clear cache api. If we add such an api, We need to build authorization > > around who can clear cache and who cannot. Only thing we need to ensure is > > people go through LensServer for alter/updates than directly hitting hive > > metastore.
Caching happens on CubeMetastoreClient level. If every update was also going through lens server then no caching issue wouldn't be there because on any update the local cache is also updated. But for updates going by another path(e.g. by creating a CubeMetastoreClient instance in a separate JVM), then the cache kept by the CubeMetastoreClient instance in lens-server would not be cleared. So with the current design, creating a resource method is required. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30030/#review68697 ----------------------------------------------------------- On Jan. 20, 2015, 9:17 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30030/ > ----------------------------------------------------------- > > (Updated Jan. 20, 2015, 9:17 a.m.) > > > Review request for lens. > > > Bugs: LENS-201 > https://issues.apache.org/jira/browse/LENS-201 > > > Repository: lens > > > Description > ------- > > methods to clear cache added > > Need to add automatic calls when updation of dims/facts is called. > > Also need to add test cases > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 42f5e0a > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > cd50c7b > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 9ef89f6 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7194f6c > > Diff: https://reviews.apache.org/r/30030/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
