----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30159/#review69150 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java <https://reviews.apache.org/r/30159/#comment113775> System.currentTimeMillis is enough? Prevents creating temp object. lens-server/pom.xml <https://reviews.apache.org/r/30159/#comment113776> Is this only for test scope? I couldn't find any hard dependency in main code. - Jaideep dhok On Jan. 22, 2015, 8:54 a.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30159/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2015, 8:54 a.m.) > > > Review request for lens and Jaideep dhok. > > > Bugs: LENS-223 > https://issues.apache.org/jira/browse/LENS-223 > > > Repository: lens > > > Description > ------- > > Changes include : > * Makes the lens-server tests run with two drivers > * Fixes createResourceQuery to properly create query context > * Cleaned up QueryContext constructors - Now there are only two constructors > - one passing query, other passing PreparedQueryContext. > * Added utility createContextWithSingleDriver for creating context with > single driver - used in resource query, explain query and tests > > > Diffs > ----- > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 64bc281 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > c63a256 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 1b4982a > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > 7534d89 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > e1988d4 > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java > bc480ec > > lens-server-api/src/main/java/org/apache/lens/server/api/query/FinishedLensQuery.java > 0971f86 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > abaa5f0 > lens-server/pom.xml 10accd9 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c95a948 > lens-server/src/test/resources/jdbcdriver-site.xml PRE-CREATION > lens-server/src/test/resources/lens-site.xml ebf4ddb > > Diff: https://reviews.apache.org/r/30159/diff/ > > > Testing > ------- > > TestSessionResource passes with changes, was failing without fix when running > with two drivers. Will update full test run, once i'm done. > > > Thanks, > > Amareshwari Sriramadasu > >
