[ 
https://issues.apache.org/jira/browse/LENS-230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290401#comment-14290401
 ] 

Amareshwari Sriramadasu commented on LENS-230:
----------------------------------------------

Review request - https://reviews.apache.org/r/30242/.

The license header is not included in images, *.data files mostly used to load 
data into tables in tests and examples, and *.js files. All source files 
without header are the following :
* .reviewboardrc
* README.md
* src/site/datalayout.pptx
* src/site/diagrams.pptx
* src/site/resources/images/apache-incubator-logo.png
* src/site/resources/images/apache-lens-logo.png
* src/site/resources/images/arch.png
* src/site/resources/images/data-layout.png
* src/site/resources/images/deployment.png
* src/site/resources/images/querystate.png
* src/site/resources/images/serverdesign.png
* lens-cli/src/test/resources/data.data
* lens-driver-hive/src/test/resources/priority_tests.data
* lens-driver-hive/testdata/testdata1.data
* lens-driver-hive/testdata/testdata2.data
* lens-examples/src/main/resources/dim1-local.data
* lens-examples/src/main/resources/dim2-local.data
* lens-examples/src/main/resources/dim4-local.data
* lens-examples/src/main/resources/fact1-local1.data
* lens-examples/src/main/resources/fact1-local2.data
* lens-examples/src/main/resources/fact1-local3.data
* lens-examples/src/main/resources/fact2-local1.data
* lens-examples/src/main/resources/fact2-local2.data
* lens-examples/src/main/resources/fact2-local3.data
* lens-examples/src/main/resources/raw-local1.data
* lens-examples/src/main/resources/raw-local2.data
* lens-examples/src/main/resources/raw-local3.data
* lens-examples/src/main/resources/raw-local4.data
* lens-examples/src/main/resources/raw-local5.data
* lens-examples/src/main/resources/raw-local6.data
* lens-ml-lib/data/naive_bayes/naive_bayes_train.data
* lens-server/src/main/webapp/static/css/codemirror.min.css
* lens-server/src/main/webapp/static/js/libs/codemirror.min.js
* lens-server/src/main/webapp/static/js/libs/jquery.flot.js
* lens-server/src/main/webapp/static/js/libs/moment.js
* lens-server/src/main/webapp/static/js/libs/sql.js
* lens-server/src/main/webapp/static/js/libs/stupidtable.min.js
* lens-server/src/test/resources/user/propertybased.data
* lens-server/testdata/testdata2.data

Will update NOTICE file for above as part of LENS-219 

> Clean up license headers
> ------------------------
>
>                 Key: LENS-230
>                 URL: https://issues.apache.org/jira/browse/LENS-230
>             Project: Apache Lens
>          Issue Type: Sub-task
>          Components: build
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 2.0
>
>
> We have apache-rat exclusion for following:
> {noformat}
>           <excludes>
>             <exclude>**/*.txt</exclude>
>             <exclude>.git/**</exclude>
>             <exclude>.reviewboardrc</exclude>
>             <exclude>.idea/**</exclude>
>             <exclude>**/*.twiki</exclude>
>             <exclude>**/*.iml</exclude>
>             <exclude>**/target/**</exclude>
>             <exclude>**/activemq-data/**</exclude>
>             <exclude>**/build/**</exclude>
>             <exclude>*.patch</exclude>
>             <exclude>**/*.log</exclude>
>             <exclude>**/logs/**</exclude>
>             <exclude>**/.classpath</exclude>
>             <exclude>**/.project</exclude>
>             <exclude>**/.checkstyle</exclude>
>             <exclude>**/.settings/**</exclude>
>             <exclude>**/test-output/**</exclude>
>             <exclude>**/maven-eclipse.xml</exclude>
>             <exclude>**/.externalToolBuilders/**</exclude>
>             <exclude>.gitignore</exclude>
>             <exclude>README.*</exclude>
>             <exclude>**/*.diff</exclude>
>             <exclude>**/*.png</exclude>
>             <exclude>**/*.pptx</exclude>
>             <exclude>**/*.jar</exclude>
>             <exclude>**/*.data</exclude>
>             <exclude>**/control</exclude>
>             <exclude>**/query_logs/**</exclude>
>           </excludes>
> {noformat}
> This is clean the above list and add the missing ones like js and add the 
> NOTICE wrt skipped files.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to