----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30251/#review69559 -----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30251/#comment114254> Add annotation with documentation describing what this is. And also mention it is only indicative value. lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java <https://reviews.apache.org/r/30251/#comment114253> Let us add the property only if the value is not -1 lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java <https://reviews.apache.org/r/30251/#comment114255> We should return is the property is not defined. lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java <https://reviews.apache.org/r/30251/#comment114256> For inline attribute, the numOfDistinctValues will be size of values directly. lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java <https://reviews.apache.org/r/30251/#comment114257> We need to add for chain column constructor as well. lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java <https://reviews.apache.org/r/30251/#comment114258> Update cube/dimension creation to pass value on of the dim attribute - Amareshwari Sriramadasu On Jan. 25, 2015, 9 a.m., Raju Bairishetti wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30251/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 9 a.m.) > > > Review request for lens, Amareshwari Sriramadasu and Jaideep dhok. > > > Bugs: LENS-68 > https://issues.apache.org/jira/browse/LENS-68 > > > Repository: lens > > > Description > ------- > > Dim attributes should contain number of possible distinct values it can take. > This can be an approximate number. This would give an idea of how big the > grouping will be when an attribute is chosen for groupby expressions > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f75ea60 > lens-cube/src/main/java/org/apache/lens/cube/metadata/BaseDimAttribute.java > 2c0e70d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/InlineDimAttribute.java > 140f284 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 6b81cae > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 4f283ad > > lens-cube/src/main/java/org/apache/lens/cube/metadata/ReferencedDimAtrribute.java > ab06db9 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > f9e9f3d > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 8bf9f81 > > Diff: https://reviews.apache.org/r/30251/diff/ > > > Testing > ------- > > Added a checks in the existing unit tests > > > Thanks, > > Raju Bairishetti > >
