----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30253/#review69742 -----------------------------------------------------------
Mostly English + consistency related comments. lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114516> Grammatical -- just say "or can be a derived cube" (Remove XCube) Also, say for which "the user" or say "users" lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114517> associated with it other than those of the parent lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114525> Do you want to separate time and dim? Like time.dm? They are two different words, right? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114526> Did you mean to say that "there should be derived cubes defined that should group the queriable fileds" lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114527> with it lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114528> can this be x_join_chain. Just to be consistent with the rest of the taxonomy? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114529> That need to be set are --> Or should it read That 'could' be set are. Need looks like required lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114530> which is propogated to the cube lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114531> from when the measure ... (remove on) lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114532> Do you want to add something like "Lens does not do any validation based on this value" lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114549> why not x_chain_column lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114548> +100. Using examples like this goes a long way in understanding :) lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114533> nit. -storage? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114547> why not update_period lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114534> Is this "Possible values" or "Example values". If these are the only possible, do you want to enum it? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114546> belongs? Should we say associated? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114545> Columns should in the same order as in the underlying physical table lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114544> See flattened_columns comment. Can we rephrase like that? lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114543> in which the table is present lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114542> external or managed | External or Managed. #consistecy :) lens-api/src/main/resources/cube-0.1.xsd <https://reviews.apache.org/r/30253/#comment114541> Can we rephrase this? This specification is used by the LENS API to return this information to the end user - Jothi Padmanabhan On Jan. 25, 2015, 12:22 p.m., Amareshwari Sriramadasu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30253/ > ----------------------------------------------------------- > > (Updated Jan. 25, 2015, 12:22 p.m.) > > > Review request for lens, Jaideep dhok and Jothi Padmanabhan. > > > Bugs: LENS-236 > https://issues.apache.org/jira/browse/LENS-236 > > > Repository: lens > > > Description > ------- > > Main changes include : > > * Adding comments in cube xsd > * Separated XCube as abstract class , and derived classes for XBaseCube and > XDerivedCube > * Remove unnecessary collection types > * Enumeration added for column types, measure types and update periods > * JoinChain definition changed to Paths consisting of edges, where each edge > has pair of references > * Made storage table elements part of fact table and dimension table > defintion. Removed confusing Update_period_element after that. > * Moved table_name to flattedcolumn it self and removed from > measure/expression/attribute definition > > Still TODO : > * Fix skewed info definition > * Update java client and examples to use changed xsd definition > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd f75ea60 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > 42f5e0a > lens-cube/src/main/java/org/apache/lens/cube/metadata/JoinChain.java > 59c3727 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 1acab08 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 9ef89f6 > lens-server/src/main/java/org/apache/lens/server/metastore/JAXBUtils.java > 2a9566f > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7194f6c > > lens-server/src/main/java/org/apache/lens/server/ui/MetastoreUIResource.java > 808f7e6 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 8bf9f81 > > Diff: https://reviews.apache.org/r/30253/diff/ > > > Testing > ------- > > TestMetastoreService passes with changes > > > Thanks, > > Amareshwari Sriramadasu > >
